Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove leftover macos9 support code #52156

Closed
ronaldoussoren opened this issue Feb 11, 2010 · 6 comments
Closed

remove leftover macos9 support code #52156

ronaldoussoren opened this issue Feb 11, 2010 · 6 comments
Assignees
@ronaldoussoren
Labels
OS-mac type-bug An unexpected behavior, bug, or error

Comments

@ronaldoussoren
Copy link
Contributor

BPO 7908
Nosy @ronaldoussoren, @merwok
Files
  • remove-platform-mac.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ronaldoussoren'
closed_at = <Date 2010-05-05.19:12:46.105>
created_at = <Date 2010-02-11.14:35:06.295>
labels = ['OS-mac', 'type-bug']
title = 'remove leftover macos9 support code'
updated_at = <Date 2011-03-20.13:29:10.485>
user = 'https://github.com/ronaldoussoren'

    bugs.python.org fields:

    activity = <Date 2011-03-20.13:29:10.485>
actor = 'eric.araujo'
assignee = 'ronaldoussoren'
closed = True
closed_date = <Date 2010-05-05.19:12:46.105>
closer = 'ronaldoussoren'
components = ['macOS']
creation = <Date 2010-02-11.14:35:06.295>
creator = 'ronaldoussoren'
dependencies = []
files = ['16211']
hgrepos = []
issue_num = 7908
keywords = ['patch', 'needs review']
message_count = 6.0
messages = ['99209', '99227', '99384', '105076', '120584', '131492']
nosy_count = 2.0
nosy_names = ['ronaldoussoren', 'eric.araujo']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue7908'
versions = ['Python 2.7', 'Python 3.2']
    @ronaldoussoren
    Copy link
    Contributor Author

    The attached patch removes all traces to os.name == 'mac' from the source tree (setup.py and stdlib), that is the leftover traces for MacOS9 support.

    A simular patch needs to be created of the 3.x tree.

    @ronaldoussoren ronaldoussoren self-assigned this Feb 11, 2010
    @ronaldoussoren ronaldoussoren added OS-mac type-bug An unexpected behavior, bug, or error labels Feb 11, 2010
    @ronaldoussoren
    Copy link
    Contributor Author

    The reason I'd like a patch review is that it affects a lot of files and want a second pair of eyes to check that I haven't been too agressive.

    The patch itself doesn't cause regressions in the unittests.

    @merwok
    Copy link
    Member

    merwok commented Feb 16, 2010

    Hello

    Some removals are unfinished, e.g.

    •    if platform not in ['mac']:

    + if platform not in []:

    → remove the test and dedent the suite;

    •    if platform not in ['mac', 'win32']:

    + if platform not in ['win32']:

    → if platform != 'win32':

    Regards

    @ronaldoussoren
    Copy link
    Contributor Author

    Removed traces of MacOS9 support in r80804 (trunk) and r80805 (3.2)

    @merwok
    Copy link
    Member

    merwok commented Nov 6, 2010

    FTR, see also bpo-9508.

    @merwok
    Copy link
    Member

    merwok commented Mar 20, 2011

    I’ve just noticed this problem:

    --- a/Misc/BeOS-setup.py
+++ b/Misc/BeOS-setup.py
@@ -356,7 +356,7 @@ class PyBuildExt(build_ext):
                                    libraries = dblib) )
 
         # Unix-only modules
-        if platform not in ['mac', 'win32']:
+        if platform == 'win32':

    The logic is reversed. Shall I fix it in all affected branches?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ronaldoussoren ronaldoussoren

    Labels
    OS-mac type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @merwok @ronaldoussoren