Rename BadZipfile to BadZipFile for consistency #51600

Retro · 2009-11-18T19:12:35Z

BPO	7351
Nosy	@birkenfeld, @pitrou, @ezio-melotti, @merwok
Files	zipfile-patch.diff issue7351-complete.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-10-28.06:39:44.829>
created_at = <Date 2009-11-18.19:12:34.863>
labels = ['interpreter-core', 'type-feature']
title = 'Rename BadZipfile to BadZipFile for consistency'
updated_at = <Date 2010-10-28.14:14:18.409>
user = 'https://bugs.python.org/Retro'

bugs.python.org fields:

activity = <Date 2010-10-28.14:14:18.409>
actor = 'eric.araujo'
assignee = 'none'
closed = True
closed_date = <Date 2010-10-28.06:39:44.829>
closer = 'georg.brandl'
components = ['Interpreter Core']
creation = <Date 2009-11-18.19:12:34.863>
creator = 'Retro'
dependencies = []
files = ['15365', '19389']
hgrepos = []
issue_num = 7351
keywords = ['patch']
message_count = 25.0
messages = ['95442', '95445', '95453', '95473', '95477', '95485', '95488', '95505', '96690', '96691', '100182', '119730', '119734', '119744', '119745', '119746', '119747', '119748', '119758', '119780', '119782', '119783', '119784', '119785', '119787']
nosy_count = 6.0
nosy_names = ['georg.brandl', 'ixokai', 'pitrou', 'ezio.melotti', 'eric.araujo', 'Retro']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue7351'
versions = ['Python 3.2']

Retro · 2009-11-18T19:12:34Z

There are some minor typos in the docs. The section zipfile has twp typos:

exception zipfile.BadZipfile
The error raised for bad ZIP files (old name: zipfile.error).

this should be

exception zipfile.BadZipFile
The error raised for bad ZIP files (old name: zipfile.error).

Note: There needs to be a capital F in the exception class name BadZipFile.

There's also a typo in the sentence "Decryption is extremely slow as it
is implemented in native python rather than C." which should be
"Decryption is extremely slow as it is implemented in native Python
rather than C." This sentence is found just above the previous
BadZipfile typo.

Note: The word 'python' is needed to be capitalized.

These typos exist since the creation of the zipfile docs. Please correct
the docs for the selected versions. Thank you.

birkenfeld · 2009-11-18T19:40:06Z

BadZipfile is actually the correct name of the exception.

Fixed the other nit in r76376.

Retro · 2009-11-18T20:54:52Z

Thanks for upcassing 'Python'.

I have to ask you why are all other classes named in the form of
...ZipFile, like

exception: LargeZipFile
class: ZipFile
class: PyZipFile

Please at least consider of making the class BadZipfile consistent to
other classes and let it be renamed to BadZipFile. Thank you again.

Retro · 2009-11-19T14:23:00Z

I suggest renaming the class from BadZipfile to BadZipFile. We have a
class named LargeZipFile. It would make sence to have the previously
mentioned class named as BadZipFile then. What is your verdict on that?

ezio-melotti · 2009-11-19T14:41:26Z

The old name could be deprecated and replaced by the right one, but as
Eric Smith mentioned on #python-dev, the class with the old name can't
be removed because - even if unlikely - the object might exist in a pickle.
So we can either live with the wrong name or deprecate it, fix the
places where it's used and live with a deprecated version that can't be
removed.

Retro · 2009-11-19T16:09:52Z

I am merely speaking of renaming the class name from BadZipfile to
BadZipFile.

class BadZipFile(exceptions.Exception):
    # etc.

Only the name is fixed at class definition. I am aiming for that in this
bug report. And then every other BadZipfile should be fixed to
BadZipFile. Is that doable?

ezio-melotti · 2009-11-19T16:24:01Z

It might be doable for Python and its stdlib, but all the programs and
modules that are using the old name will start raising errors if they
don't find the old name anymore.
If the old name is deprecated for at least one Python version (e.g.
2.7/3.2), these programs can fix it and then, after a few versions (e.g.
3.3), the old name can finally be removed.
There is still the pickle issue, even if IMHO it's so unlikely that it
shouldn't be relevant.

Retro · 2009-11-19T17:48:20Z

I made a patch which fixes the BadZipfile issue. Please take a look and
decide whether you'll toss it or use it. Maybe it'll come handy some
other time in the future.

merwok · 2009-12-20T15:41:35Z

Your patch need to include an alias (BadZipfile = BadZipFile) to
preserve compatibility with old pickles, as explains msg95477.

Cheers

pitrou · 2009-12-20T15:42:18Z

While the mismatched casing is unfortunate, I don't think changing it
for the sake of aesthetics is a good deal given that many existing
programs will have to be converted to the new spelling.

ezio-melotti · 2010-02-27T11:39:13Z

Unless we are going to add an alias for BadZipfile, I'll close this as won't fix.

Retro · 2010-10-27T20:16:33Z

I'm reopening this and I am making it a feature request for Python 3.2

merwok · 2010-10-27T20:43:26Z

Boštjan, you need to update your patch to add the missing alias to the old name, as well as docs and test updates.

I’m +0 on the change.

Retro · 2010-10-27T23:57:29Z

I am -1 for the alias. I want that this gets renamed in Python 3.2, not
aliased. I don't care about old pickles. Anyway, who has BadZipfile object
pickled? Just incorporate my patch and fix the docs and any test
cases/units. Thanks.

On Wed, Oct 27, 2010 at 10:43 PM, Éric Araujo <report@bugs.python.org>wrote:

Éric Araujo <merwok@netwok.org> added the comment:

Boštjan, you need to update your patch to add the missing alias to the old
name, as well as docs and test updates.

I’m +0 on the change.

----------
stage: committed/rejected -> patch review
title: Documentation typos found in "zipfile — Work with ZIP archives" ->
Rename BadZipfile to BadZipFile for consistency

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue7351\>

ixokai · 2010-10-28T00:11:40Z

You may "not care" about backwards compatibility, but introducing a breaking change in 3.2 for mere style-conformity is not OK, IMO. If the patcher insists on it being a breaking change, it should be rejected.

FWIW, this casing is sufficiently bizarre and inconsistent in the module itself, that it seems clearly wrong and likely to produce difficulties for people using it-- so although I'm not upgrading to Python3 anytime soon, I'd really like to change my code to be BadZipFile when I do, so I'd be +1 with an alias. :)

Retro · 2010-10-28T00:29:53Z

No alias. Be stubborn and let the stdlib die in inconsistency.

On Thu, Oct 28, 2010 at 2:11 AM, Stephen Hansen <report@bugs.python.org>wrote:

Stephen Hansen <me+python@ixokai.io <me%2Bpython@ixokai.io>> added the
comment:

You may "not care" about backwards compatibility, but introducing a
breaking change in 3.2 for mere style-conformity is not OK, IMO. If the
patcher insists on it being a breaking change, it should be rejected.

FWIW, this casing is sufficiently bizarre and inconsistent in the module
itself, that it seems clearly wrong and likely to produce difficulties for
people using it-- so although I'm not upgrading to Python3 anytime soon, I'd
really like to change my code to be BadZipFile when I do, so I'd be +1 with
an alias. :)

----------
nosy: +ixokai

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue7351\>

ixokai · 2010-10-28T01:04:41Z

Considering I do use zipfiles a lot, I slightly care about this (at least, eventually)-- I'm attaching a new patch, with doc and test changes as well (and the compatibility alias).

What convinced me was looking at test_zipfile, and noticing how often it actually confused the issue in comments at least, between typing BadZipfile and BadZipFile.

Dunno if I worded the doc-change well, so you may want to adjust that.

ixokai · 2010-10-28T01:06:34Z

Oh: and I tested it against branches/py3k in the head, it applies cleanly and builds, and test_zipfile runs without error.

birkenfeld · 2010-10-28T06:42:47Z

Applied after review in r85874. (Please make sure your patches don't have trailing whitespace.)

merwok · 2010-10-28T13:50:20Z

A “BadZipZile” in the patch made it to Subversion :) Fixed in r85891.

birkenfeld · 2010-10-28T13:57:07Z

Thanks for the catch!

Retro · 2010-10-28T14:00:06Z

Is the trailing whitespace problem solved? Please make sure everything is
correct and that no more typos occur for this issue. And I am the original
patch author, so mention my name (Boštjan Mejak) in the NEWS file. Thanks.

On Thu, Oct 28, 2010 at 8:42 AM, Georg Brandl <report@bugs.python.org>wrote:

Georg Brandl <georg@python.org> added the comment:

Applied after review in r85874. (Please make sure your patches don't have
trailing whitespace.)

----------

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue7351\>

birkenfeld · 2010-10-28T14:05:46Z

a) I already removed the whitespace before committing. The pre-commit hook wouldn't even allow committing that.

b) I don't think constant refusal to submit a patch in the way we request earns you a place in the acknowledgements.

merwok · 2010-10-28T14:05:57Z

Is the trailing whitespace problem solved?
You can follow the link to the revision to see that it is. Georg’s message implied this, too.

Please make sure everything is correct and that no more typos occur for this issue.
We do.

And I am the original patch author, so mention my name (Boštjan Mejak) in the NEWS file. Thanks.
We don’t add names for very small patches like this one.

(P.S. Would you be so kind as to follow some netiquette in the tracker? HTML email creates noisy unnamed attachments, and top-posting is redundant and hard to read. Thanks in advance.)

Retro · 2010-10-28T14:11:47Z

Then disable the tracker's ability to post messages via POP/IMAP. Just block
those protocols in the tracker and you won't see any gibberish anymore. ;)

On Thu, Oct 28, 2010 at 4:05 PM, Éric Araujo <report@bugs.python.org> wrote:

Éric Araujo <merwok@netwok.org> added the comment:

> Is the trailing whitespace problem solved?
You can follow the link to the revision to see that it is. Georg’s message
implied this, too.

> Please make sure everything is correct and that no more typos occur for
this issue.
We do.

> And I am the original patch author, so mention my name (Boštjan Mejak) in
the NEWS file. Thanks.
We don’t add names for very small patches like this one.

(P.S. Would you be so kind as to follow some netiquette in the tracker?
HTML email creates noisy unnamed attachments, and top-posting is redundant
and hard to read. Thanks in advance.)

----------

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue7351\>

Retro mannequin added the docs Documentation in the Doc dir label Nov 18, 2009

Retro mannequin assigned birkenfeld Nov 18, 2009

birkenfeld closed this as completed Nov 18, 2009

Retro mannequin reopened this Nov 18, 2009

birkenfeld closed this as completed Aug 10, 2010

Retro mannequin added interpreter-core (Objects, Python, Grammar, and Parser dirs) and removed docs Documentation in the Doc dir labels Oct 27, 2010

Retro mannequin reopened this Oct 27, 2010

Retro mannequin added the type-feature A feature request or enhancement label Oct 27, 2010

birkenfeld removed their assignment Oct 27, 2010

merwok changed the title ~~Documentation typos found in "zipfile — Work with ZIP archives"~~ Rename BadZipfile to BadZipFile for consistency Oct 27, 2010

birkenfeld closed this as completed Oct 28, 2010

ezio-melotti transferred this issue from another repository Apr 10, 2022

hugovk mentioned this issue Mar 13, 2023

Remove the error and the zipfile.ZipFile.BadZipfile aliases #86437

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename BadZipfile to BadZipFile for consistency #51600

Rename BadZipfile to BadZipFile for consistency #51600

Retro mannequin commented Nov 18, 2009

Retro mannequin commented Nov 18, 2009

birkenfeld commented Nov 18, 2009

Retro mannequin commented Nov 18, 2009

Retro mannequin commented Nov 19, 2009

ezio-melotti commented Nov 19, 2009

Retro mannequin commented Nov 19, 2009

ezio-melotti commented Nov 19, 2009

Retro mannequin commented Nov 19, 2009

merwok commented Dec 20, 2009

pitrou commented Dec 20, 2009

ezio-melotti commented Feb 27, 2010

Retro mannequin commented Oct 27, 2010

merwok commented Oct 27, 2010

Retro mannequin commented Oct 27, 2010

ixokai mannequin commented Oct 28, 2010

Retro mannequin commented Oct 28, 2010

ixokai mannequin commented Oct 28, 2010

ixokai mannequin commented Oct 28, 2010

birkenfeld commented Oct 28, 2010

merwok commented Oct 28, 2010

birkenfeld commented Oct 28, 2010

Retro mannequin commented Oct 28, 2010

birkenfeld commented Oct 28, 2010

merwok commented Oct 28, 2010

Retro mannequin commented Oct 28, 2010

Rename BadZipfile to BadZipFile for consistency #51600

Rename BadZipfile to BadZipFile for consistency #51600

Comments

Retro mannequin commented Nov 18, 2009

Retro mannequin commented Nov 18, 2009

birkenfeld commented Nov 18, 2009

Retro mannequin commented Nov 18, 2009

Retro mannequin commented Nov 19, 2009

ezio-melotti commented Nov 19, 2009

Retro mannequin commented Nov 19, 2009

ezio-melotti commented Nov 19, 2009

Retro mannequin commented Nov 19, 2009

merwok commented Dec 20, 2009

pitrou commented Dec 20, 2009

ezio-melotti commented Feb 27, 2010

Retro mannequin commented Oct 27, 2010

merwok commented Oct 27, 2010

Retro mannequin commented Oct 27, 2010

ixokai mannequin commented Oct 28, 2010

Retro mannequin commented Oct 28, 2010

ixokai mannequin commented Oct 28, 2010

ixokai mannequin commented Oct 28, 2010

birkenfeld commented Oct 28, 2010

merwok commented Oct 28, 2010

birkenfeld commented Oct 28, 2010

Retro mannequin commented Oct 28, 2010

birkenfeld commented Oct 28, 2010

merwok commented Oct 28, 2010

Retro mannequin commented Oct 28, 2010