Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_lib2to3 failure under Windows #51515

Closed
pitrou opened this issue Nov 5, 2009 · 4 comments
Closed

test_lib2to3 failure under Windows #51515

pitrou opened this issue Nov 5, 2009 · 4 comments
Labels
easy OS-windows tests Tests in the Lib/test dir topic-2to3 type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Nov 5, 2009

BPO 7266
Nosy @pitrou, @benjaminp, @bitdancer, @meadori

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-11-02.12:43:30.368>
created_at = <Date 2009-11-05.15:06:29.072>
labels = ['easy', 'tests', 'type-bug', 'expert-2to3', 'OS-windows']
title = 'test_lib2to3 failure under Windows'
updated_at = <Date 2010-11-02.12:43:30.367>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2010-11-02.12:43:30.367>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2010-11-02.12:43:30.368>
closer = 'benjamin.peterson'
components = ['Tests', 'Windows', '2to3 (2.x to 3.x conversion tool)']
creation = <Date 2009-11-05.15:06:29.072>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 7266
keywords = ['easy']
message_count = 4.0
messages = ['94933', '94948', '94960', '98705']
nosy_count = 4.0
nosy_names = ['pitrou', 'benjamin.peterson', 'r.david.murray', 'meador.inge']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'needs patch'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue7266'
versions = ['Python 2.7']
@pitrou
Copy link
Member Author

pitrou commented Nov 5, 2009

test_lib2to3 fails deterministically on the Windows buildbots:

test test_lib2to3 failed -- Traceback (most recent call last):
  File
"E:\cygwin\home\db3l\buildarea\trunk.bolen-windows\build\lib\lib2to3\tests\test_parser.py",
line 161, in test_all_project_files
    self.fail("Idempotency failed: %s" % filepath)
AssertionError: Idempotency failed:
E:\cygwin\home\db3l\buildarea\trunk.bolen-windows\build\lib\lib2to3\fixer_base.py

If you look at the logs (*), you'll see that it's apparently just a
newline issue. Either the test should be modified to ignore newline
style changes, or lib2to3 should be fixed to output the same kind of
newlines it encountered on input.

(*) e.g.
http://www.python.org/dev/buildbot/trunk.stable/builders/x86%20XP-4%20trunk/builds/2590/steps/test/logs/stdio

@pitrou pitrou added topic-2to3 type-bug An unexpected behavior, bug, or error labels Nov 5, 2009
@benjaminp
Copy link
Contributor

I think we need someone with access to windows to propose a patch.

@benjaminp benjaminp removed their assignment Nov 5, 2009
@bitdancer
Copy link
Member

Benjamin disabled this test on windows so it is no longer causing the
buildbot to fail.

@bitdancer bitdancer added easy tests Tests in the Lib/test dir labels Nov 6, 2009
@meadori
Copy link
Member

meadori commented Feb 2, 2010

This looks to be fixed now [1]. The log shows 'test_lib2to3' passing.

BTW, why do we run through Cygwin? I think to test on Windows as most Windows developers do things we need to use the native cmd.exe shell.

[1] http://www.python.org/dev/buildbot/builders/x86%20XP-4%20trunk/builds/2931/steps/test/logs/stdio

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy OS-windows tests Tests in the Lib/test dir topic-2to3 type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benjaminp @meadori @bitdancer @pitrou