Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document changes in asynchat #51160

Closed
lehmannro mannequin opened this issue Sep 14, 2009 · 6 comments
Closed

Document changes in asynchat #51160

lehmannro mannequin opened this issue Sep 14, 2009 · 6 comments
Assignees
@josiahcarlson
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@lehmannro
Copy link
Mannequin

lehmannro mannequin commented Sep 14, 2009

BPO 6911
Nosy @birkenfeld, @giampaolo, @ezio-melotti, @CuriousLearner
Files
  • asynchat-docs.patch: patch to Doc/library/asynchat.rst
  • asynchat-docs.patch: patch Rename README to README.rst and enhance formatting #2 to Doc/library/asynchat.rst
  • asynchat-docs.patch: patch bpo-29403: Fix mock's broken autospec behavior on method-bound builtin functions #3 to Doc/library/asynchat.rst
  • asynchat-docs.patch: Update for patch bpo-29403: Fix mock's broken autospec behavior on method-bound builtin functions #3 to Doc/library/asynchat.rst
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/josiahcarlson'
closed_at = <Date 2019-05-04.19:05:51.657>
created_at = <Date 2009-09-14.15:26:58.122>
labels = ['type-feature', 'docs']
title = 'Document changes in asynchat'
updated_at = <Date 2019-05-04.19:05:51.649>
user = 'https://bugs.python.org/lehmannro'

    bugs.python.org fields:

    activity = <Date 2019-05-04.19:05:51.649>
actor = 'CuriousLearner'
assignee = 'josiahcarlson'
closed = True
closed_date = <Date 2019-05-04.19:05:51.657>
closer = 'CuriousLearner'
components = ['Documentation']
creation = <Date 2009-09-14.15:26:58.122>
creator = 'lehmannro'
dependencies = []
files = ['14888', '14889', '14893', '21116']
hgrepos = []
issue_num = 6911
keywords = ['patch']
message_count = 6.0
messages = ['92616', '92617', '92644', '130829', '220658', '341397']
nosy_count = 6.0
nosy_names = ['georg.brandl', 'giampaolo.rodola', 'lehmannro', 'ezio.melotti', 'jramnani', 'CuriousLearner']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue6911'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @lehmannro
    Copy link
    Mannequin Author

    lehmannro mannequin commented Sep 14, 2009

    asynchat.async_chat grew a _collect_incoming and a _get_data method in
    2.6. The constructor has been extended to conform to
    asyncore.dispatcher's. This should be documented.

    Apart from that, fifo and simple_producer have been deprecated, and
    async_chat.ac_out_buffer was replaced by async_chat.incoming. These are
    internals and were never documented.

    A patch is attached.

    @lehmannro lehmannro mannequin assigned birkenfeld Sep 14, 2009
    @lehmannro lehmannro mannequin added the docs Documentation in the Doc dir label Sep 14, 2009
    @lehmannro
    Copy link
    Mannequin Author

    lehmannro mannequin commented Sep 14, 2009

    Excuse me -- fifo and simple_producer are indeed documented and need a
    deprecation notice. New patch attached (plus reworded paragraph about
    async_chat.__init__).

    @lehmannro
    Copy link
    Mannequin Author

    lehmannro mannequin commented Sep 15, 2009

    I found another bug: async_chat.push still talks about automatically
    creating a simple_producer, which is no longer true.

    I added a fix to the patch.

    @jramnani
    Copy link
    Mannequin

    jramnani mannequin commented Mar 14, 2011

    This patch could no longer be applied cleanly on the 2.7 branch.

    I have updated the patch so it applies cleanly to commit 22f991bb9b0b on the 2.7 branch.

    @ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Oct 2, 2012
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jun 15, 2014

    Is it worth applying the latest patch given that asynchat is deprecated in favour of asyncio?

    @CuriousLearner
    Copy link
    Member

    Given that Python 2.x and async chat is deprecated in favor of new async io, we're better in closing this issue, rather than trying to apply this cleanly on the master branch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @josiahcarlson josiahcarlson

    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @birkenfeld @CuriousLearner @ezio-melotti