Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnetlib.py: don't block on IAC and enhancement #37387

Closed
hashao mannequin opened this issue Oct 30, 2002 · 3 comments
Closed

telnetlib.py: don't block on IAC and enhancement #37387

hashao mannequin opened this issue Oct 30, 2002 · 3 comments
Labels
stdlib Python modules in the Lib dir

Comments

@hashao
Copy link
Mannequin

hashao mannequin commented Oct 30, 2002

BPO 630829
Nosy @loewis
Files
  • telnetlib_IAC.diff: telnetlib IAC nonblocking patch
  • telnetlib_enhance.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2002-11-04.09:56:54.000>
    created_at = <Date 2002-10-30.01:35:45.000>
    labels = ['library']
    title = "telnetlib.py: don't block on IAC and enhancement"
    updated_at = <Date 2002-11-04.09:56:54.000>
    user = 'https://bugs.python.org/hashao'

    bugs.python.org fields:

    activity = <Date 2002-11-04.09:56:54.000>
    actor = 'loewis'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2002-10-30.01:35:45.000>
    creator = 'hashao'
    dependencies = []
    files = ['4666', '4667']
    hgrepos = []
    issue_num = 630829
    keywords = ['patch']
    message_count = 3.0
    messages = ['41505', '41506', '41507']
    nosy_count = 2.0
    nosy_names = ['loewis', 'hashao']
    pr_nums = []
    priority = 'high'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue630829'
    versions = ['Python 2.3']

    @hashao
    Copy link
    Mannequin Author

    hashao mannequin commented Oct 30, 2002

    Use a IAC buffer to make IAC commands not block.

    Also call callback on command other than
    WILL/WONT/DO/DONT. People still want
    to handle other commands.

    @hashao hashao mannequin closed this as completed Oct 30, 2002
    @hashao hashao mannequin added the stdlib Python modules in the Lib dir label Oct 30, 2002
    @hashao hashao mannequin closed this as completed Oct 30, 2002
    @hashao hashao mannequin added the stdlib Python modules in the Lib dir label Oct 30, 2002
    @hashao
    Copy link
    Mannequin Author

    hashao mannequin commented Oct 31, 2002

    Logged In: YES
    user_id=8717

    A new patch also handle IAC SB ... IAC SE data fetchming for
    fully handling the telnet protocol. No option will use
    chr(0) instead
    of 256. protocol handler should know if a command has option
    or not, anyway.

    Supercede the last patch.

    Please commit.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 4, 2002

    Logged In: YES
    user_id=21627

    Thanks for the patch. Committed as

    libtelnetlib.tex 1.10;
    telnetlib.py 1.20;
    ACKS 1.214;
    NEWS 1.507;

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants