Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disable_nagle_algorithm to SocketServer.TCPServer #50442

Closed
kristjanvalur mannequin opened this issue Jun 4, 2009 · 7 comments
Closed

add disable_nagle_algorithm to SocketServer.TCPServer #50442

kristjanvalur mannequin opened this issue Jun 4, 2009 · 7 comments
Assignees
@kristjanvalur
Labels
easy stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@kristjanvalur
Copy link
Mannequin

kristjanvalur mannequin commented Jun 4, 2009

BPO 6192
Nosy @pitrou, @kristjanvalur
Files
  • disable_nagle.patch
  • socketserver2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/kristjanvalur'
closed_at = <Date 2009-06-28.21:36:06.730>
created_at = <Date 2009-06-04.10:32:40.545>
labels = ['easy', 'type-feature', 'library']
title = 'add disable_nagle_algorithm to SocketServer.TCPServer'
updated_at = <Date 2009-06-28.21:36:06.729>
user = 'https://github.com/kristjanvalur'

    bugs.python.org fields:

    activity = <Date 2009-06-28.21:36:06.729>
actor = 'kristjan.jonsson'
assignee = 'kristjan.jonsson'
closed = True
closed_date = <Date 2009-06-28.21:36:06.730>
closer = 'kristjan.jonsson'
components = ['Library (Lib)']
creation = <Date 2009-06-04.10:32:40.545>
creator = 'kristjan.jonsson'
dependencies = []
files = ['14185', '14306']
hgrepos = []
issue_num = 6192
keywords = ['patch', 'easy']
message_count = 7.0
messages = ['88878', '88886', '89046', '89062', '89411', '89657', '89795']
nosy_count = 2.0
nosy_names = ['pitrou', 'kristjan.jonsson']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue6192'
versions = ['Python 3.2']
    @kristjanvalur
    Copy link
    Mannequin Author

    kristjanvalur mannequin commented Jun 4, 2009

    It is useful to be able to disable the Nagle algoritm on socket
    connections from the TCPServer. These are typically used by HTTP servers.

    If combined with write buffering (setting RequestHangler.wbufsize = -1) it
    can make sure that http responses are not subject to Nagle/Delayed-ack
    delays. Disabling Nagle in addition to providing the buffering is
    necessary to make sure that the final wfile.flush() arrives promptly, in
    case a previous flush occurred and the final flush is small.

    A patch is provided.

    @kristjanvalur kristjanvalur mannequin added easy type-feature A feature request or enhancement stdlib Python modules in the Lib dir labels Jun 4, 2009
    @pitrou
    Copy link
    Member

    pitrou commented Jun 4, 2009

    Looks ok to me.

    @kristjanvalur
    Copy link
    Mannequin Author

    kristjanvalur mannequin commented Jun 7, 2009

    Committed in revision 73272

    @kristjanvalur kristjanvalur mannequin closed this as completed Jun 7, 2009
    @pitrou
    Copy link
    Member

    pitrou commented Jun 8, 2009

    This patch should be committed to py3k after 3.1 is released.

    @pitrou pitrou reopened this Jun 8, 2009
    @kristjanvalur
    Copy link
    Mannequin Author

    kristjanvalur mannequin commented Jun 15, 2009

    On consideration, it is more appropariate to have the
    disable_nagle_algorithm as part of StreamRequestHandler rather than in the
    TCPSockerServer. It then sits right next to the rfile and wfile that
    affect it.
    The RequestHandlers aren't documented as extensively as the socket
    servers, though, so the documentation will have to go.
    Attached is a patch.

    @kristjanvalur
    Copy link
    Mannequin Author

    kristjanvalur mannequin commented Jun 24, 2009

    Second patch applied in 73546

    @kristjanvalur
    Copy link
    Mannequin Author

    kristjanvalur mannequin commented Jun 28, 2009

    Merged into py3k in revision 73648

    @kristjanvalur kristjanvalur mannequin closed this as completed Jun 28, 2009
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @kristjanvalur kristjanvalur

    Labels
    easy stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou