Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spurious empty lines in wsgiref code #50051

Closed
tarekziade mannequin opened this issue Apr 20, 2009 · 8 comments
Closed

spurious empty lines in wsgiref code #50051

tarekziade mannequin opened this issue Apr 20, 2009 · 8 comments
Assignees
Labels
stdlib Python modules in the Lib dir

Comments

@tarekziade
Copy link
Mannequin

tarekziade mannequin commented Apr 20, 2009

BPO 5801
Nosy @pjeby, @pitrou, @tarekziade, @merwok
Files
  • patch
  • wsgiref-patch: pep8fies all file in wsgiref
  • wsgiref-patch.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pjeby'
    closed_at = <Date 2010-02-23.06:02:46.109>
    created_at = <Date 2009-04-20.16:03:57.079>
    labels = ['library']
    title = 'spurious empty lines in wsgiref code'
    updated_at = <Date 2010-02-23.06:02:46.074>
    user = 'https://github.com/tarekziade'

    bugs.python.org fields:

    activity = <Date 2010-02-23.06:02:46.074>
    actor = 'tarek'
    assignee = 'pje'
    closed = True
    closed_date = <Date 2010-02-23.06:02:46.109>
    closer = 'tarek'
    components = ['Library (Lib)']
    creation = <Date 2009-04-20.16:03:57.079>
    creator = 'tarek'
    dependencies = []
    files = ['14321', '14410', '14411']
    hgrepos = []
    issue_num = 5801
    keywords = ['patch']
    message_count = 8.0
    messages = ['86200', '89460', '89482', '89526', '89951', '89952', '89953', '99899']
    nosy_count = 5.0
    nosy_names = ['pje', 'pitrou', 'tarek', 'eric.araujo', 'ptn']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue5801'
    versions = ['Python 3.1', 'Python 2.7']

    @tarekziade
    Copy link
    Mannequin Author

    tarekziade mannequin commented Apr 20, 2009

    the wsgiref package is hard to read, there are blocs of empty lines.

    Can I PEP-8-fy it ?

    @tarekziade tarekziade mannequin added the stdlib Python modules in the Lib dir label Apr 20, 2009
    @ptn
    Copy link
    Mannequin

    ptn mannequin commented Jun 17, 2009

    The patch for issue bpo-5800 solves this.

    @pitrou
    Copy link
    Member

    pitrou commented Jun 17, 2009

    +1 for making the source more readable.

    @ptn
    Copy link
    Mannequin

    ptn mannequin commented Jun 19, 2009

    I added the patch for bpo-5800

    @ptn
    Copy link
    Mannequin

    ptn mannequin commented Jun 30, 2009

    I cleaned the rest of the module by shortening lines that are too long,
    removing useless blocks of empty lines and adding whitespace around
    operators and after commas. Nothing in the programming logic was changed.

    @ptn
    Copy link
    Mannequin

    ptn mannequin commented Jun 30, 2009

    The patch applies to rev 73702 of the py3k branch.

    @ptn
    Copy link
    Mannequin

    ptn mannequin commented Jun 30, 2009

    Oops, forgot to add the .diff extension so web browsers don't get
    confused. Their contents are the same though.

    @tarekziade
    Copy link
    Mannequin Author

    tarekziade mannequin commented Feb 23, 2010

    empty lines were removed in r78367, r78369

    @tarekziade tarekziade mannequin closed this as completed Feb 23, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant