New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support telling TestResult objects a test run has finished #49978
Comments
Original mail: Some uses for this are:
This can be added quite safely I think - check for the attribute, and if done() could be spelt differently - I don't think anyone would care. |
Now, some refinements, as usual (for me at least) when considering a Firstly, I said you can infer starting. But its asymmetrical to have a Secondly, TestCase.run(None) creates a result. I think it would be good "Whomever calls 'start' is responsible for calling 'done'." Concretely Thirdly, naming. I'm agnostic, but I'd lean towards something clear, and If this all makes sense, I'll write up some tests and put a patch |
startTestRun and stopTestRun sound good to me. |
Quite useful! Names are hard, but the ones proposed are pretty good. |
I've written up a patch for this; it works with old result classes too. Hopefully the bugtracker will attach it in reply to this mail; if not -Rob |
The patch looks fine to me, except that it's missing documentation |
On Wed, 2009-04-15 at 23:19 +0000, Barry A. Warsaw wrote:
Where do the docs go? -Rob |
On Apr 15, 2009, at 7:43 PM, Robert Collins wrote:
|
Updates - docs, and fixes a couple of stubbed out upcalls in the logging |
Committed in revision 72225. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: