New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more pickling tests #49915
Comments
The attached patch adds more tests for pickling:
I'll port to py3k after reviewed for trunk. |
Overall, the patch looks good. I haven't reviewed the patch thoroughly In test_many_puts_and_gets(), I believe this: for proto in [0, 1, 2]:
... should be changed to: for proto in protocols:
... Also, I think the tests in AbstractPicklerUnpicklerObjectTests could be And one last thing, why AbstractCompatTests is hard-coded to use |
I've made test_xpickle support Python 2.4 because it uses Python 2.4, I made AbstractCompatTests use cPickle because that's what I've been I agree with your other points. |
How much is "very slow"? If it's less than 10-15 seconds I think it's ok. |
test_xpickle currently takes over three minutes on my MacBook Pro to |
We took a similar issue in test_decimal and came up with a better |
Ouch! A couple of minutes is already too much for a single test IMHO. I |
Raymond, how would you reconcile your random approach with the fact that |
The buildbots should be running with the resource enabled (run the full If we need the reproducible results with the resource disabled, then a The idea to run some random tests when the resource flag is disabled |
Updated the patch to include a regrtest xpickle resource, which Added backwards compat tests for the pure-Python pickle module. Total Also addressed the comment about [0, 1, 2] -> protocols. |
If no-one has any objections to the xpickle resource included in the |
Ok if it doesn't take too long to run the tests (which may imply Thanks for your work, cheers Antoine. |
I did something similar: if you don't pass the -uxpickle flag to |
Collin, can you port these new tests to Py3k? |
Yes, I'm porting them. I got started, but got distracted by other things |
Ok. Thank you! |
Committed as r71408 (trunk) and r71638 (py3k). |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: