Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 535444 super() broken w/classmethods #36364

Closed
pjeby mannequin opened this issue Mar 31, 2002 · 6 comments
Closed

bug 535444 super() broken w/classmethods #36364

pjeby mannequin opened this issue Mar 31, 2002 · 6 comments
Assignees
@gvanrossum
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@pjeby
Copy link
Mannequin

pjeby mannequin commented Mar 31, 2002

BPO 537536
Nosy @mwhudson, @gvanrossum, @loewis, @pjeby
Files
  • superpatch
  • testpatch: Patch to test_descr.py to test for bug 535444
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2002-04-02.19:04:49.000>
created_at = <Date 2002-03-31.23:12:23.000>
labels = ['interpreter-core']
title = 'bug 535444 super() broken w/classmethods'
updated_at = <Date 2002-04-02.19:04:49.000>
user = 'https://github.com/pjeby'

    bugs.python.org fields:

    activity = <Date 2002-04-02.19:04:49.000>
actor = 'gvanrossum'
assignee = 'gvanrossum'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2002-03-31.23:12:23.000>
creator = 'pje'
dependencies = []
files = ['4103', '4104']
hgrepos = []
issue_num = 537536
keywords = ['patch']
message_count = 6.0
messages = ['39441', '39442', '39443', '39444', '39445', '39446']
nosy_count = 4.0
nosy_names = ['mwh', 'gvanrossum', 'loewis', 'pje']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue537536'
versions = ['Python 2.2']
    @pjeby
    Copy link
    Mannequin Author

    pjeby mannequin commented Mar 31, 2002

    This patch fixes bug bpo-535444. It is against the
    current CVS version of Python, and addresses the
    problem by adding a 'starttype' variable to
    'super_getattro', which works the same as 'starttype'
    in the pure-Python version of super in the descriptor
    tutorial. This variable is then passed to the
    descriptor __get__ function, ala
    'descriptor.__get__(self.__obj__,starttype)'.

    This patch does not correct the pure-Python version of
    'super' in the descriptor tutorial; I don't know where
    that file is or how to submit a patch for it.

    This patch also does not include a regression test for
    the bug. I do not know what would be considered the
    appropriate test script to place this in.

    Thanks.

    @pjeby pjeby mannequin closed this as completed Mar 31, 2002
    @pjeby pjeby mannequin assigned gvanrossum Mar 31, 2002
    @pjeby pjeby mannequin closed this as completed Mar 31, 2002
    @pjeby pjeby mannequin added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Mar 31, 2002
    @pjeby pjeby mannequin assigned gvanrossum Mar 31, 2002
    @pjeby pjeby mannequin added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Mar 31, 2002
    @mwhudson
    Copy link

    mwhudson commented Apr 1, 2002

    Logged In: YES
    user_id=6656

    Guido gets the fix too.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Apr 1, 2002

    Logged In: YES
    user_id=21627

    Please put tests for this stuff into test_descr.py.

    @pjeby
    Copy link
    Mannequin Author

    pjeby mannequin commented Apr 1, 2002

    Logged In: YES
    user_id=56214

    Here's the regression test. It asserts 6 things, 5 of which
    will fail without the typeobject.c patch to super() in
    place. Thanks.

    @gvanrossum
    Copy link
    Member

    Logged In: YES
    user_id=6380

    Accepted, also as bugfix for 2.2.1 (assuming it works there,
    not tested).

    I can check this in in the morning.

    Thanks all!

    @gvanrossum
    Copy link
    Member

    Logged In: YES
    user_id=6380

    Committed to the trunk. I'll leave it to Michael to commit
    it to 2.2.1.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gvanrossum gvanrossum

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @mwhudson @gvanrossum