Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseCookie.load doesn't create Morsel objects for mappings #49525

Closed
eggy mannequin opened this issue Feb 15, 2009 · 2 comments
Closed

BaseCookie.load doesn't create Morsel objects for mappings #49525

eggy mannequin opened this issue Feb 15, 2009 · 2 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@eggy
Copy link
Mannequin

eggy mannequin commented Feb 15, 2009

BPO 5275
Nosy @birkenfeld

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-09-04.08:17:17.607>
created_at = <Date 2009-02-15.22:49:50.018>
labels = ['type-bug']
title = "BaseCookie.load doesn't create Morsel objects for mappings"
updated_at = <Date 2009-09-04.08:17:17.605>
user = 'https://bugs.python.org/eggy'

bugs.python.org fields:

activity = <Date 2009-09-04.08:17:17.605>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = <Date 2009-09-04.08:17:17.607>
closer = 'georg.brandl'
components = []
creation = <Date 2009-02-15.22:49:50.018>
creator = 'eggy'
dependencies = []
files = []
hgrepos = []
issue_num = 5275
keywords = []
message_count = 2.0
messages = ['82177', '92243']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'eggy']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue5275'
versions = ['Python 2.6', 'Python 2.5', 'Python 2.4', 'Python 3.0', 'Python 3.1', 'Python 2.7']
@eggy
Copy link
Mannequin Author

eggy mannequin commented Feb 15, 2009

The load method, which is also called from the initializer if input is
provided, doesn't create Morsel objects for things other than strs,
because it calls self.update(rawdata), which does not invoke the custom
__setitem__.

The documentation states that when rawdata is not a string, it must be a
dictionary and providing that will be equivalent to doing

for k, v in rawdata.items():
    cookie[k] = v

So that is what it should do :)

@eggy eggy mannequin added the type-bug An unexpected behavior, bug, or error label Feb 15, 2009
@birkenfeld
Copy link
Member

Thanks, fixed in r74647.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@birkenfeld