Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X installer: fix makefile target changed for 3.x #49522

Closed
ned-deily opened this issue Feb 15, 2009 · 8 comments
Closed

OS X installer: fix makefile target changed for 3.x #49522

ned-deily opened this issue Feb 15, 2009 · 8 comments
Labels
build The build process and cross-build OS-mac type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@ned-deily
Copy link
Member

BPO 5272
Nosy @ronaldoussoren, @benjaminp, @ned-deily
Files
  • patch-nad0003-py3k-30.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2009-05-26.21:39:32.944>
created_at = <Date 2009-02-15.09:08:33.248>
labels = ['OS-mac', 'build', 'type-crash']
title = 'OS X installer: fix makefile target changed for 3.x'
updated_at = <Date 2009-05-26.21:39:32.942>
user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2009-05-26.21:39:32.942>
actor = 'ronaldoussoren'
assignee = 'none'
closed = True
closed_date = <Date 2009-05-26.21:39:32.944>
closer = 'ronaldoussoren'
components = ['Build', 'macOS']
creation = <Date 2009-02-15.09:08:33.248>
creator = 'ned.deily'
dependencies = []
files = ['13096']
hgrepos = []
issue_num = 5272
keywords = []
message_count = 8.0
messages = ['82145', '82221', '88090', '88186', '88306', '88392', '88393', '88395']
nosy_count = 3.0
nosy_names = ['ronaldoussoren', 'benjamin.peterson', 'ned.deily']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue5272'
versions = ['Python 3.0', 'Python 3.1']
    @ned-deily
    Copy link
    Member Author

    2.x "make install" is equivalent to 3.x "make fullinstall"
    Update Mac/BuildScript/build-installer.py accordingly.
    This prevents spurious warning messages in the installer build.

    @ned-deily ned-deily added build The build process and cross-build OS-mac type-crash A hard crash of the interpreter, possibly with a core dump labels Feb 15, 2009
    @ned-deily
    Copy link
    Member Author

    Actually, it's more than just a cosmetic issue. Without the "make
    fullinstall" the bininstall target is skipped.

    @ronaldoussoren
    Copy link
    Contributor

    "make fullinstall" is wrong, this will install a "python" executable as
    well as the proper "python3" and "python3.1" executables.

    I'll do a build of the 3.1 installer ASAP and fix any issues with that.

    @ned-deily
    Copy link
    Member Author

    With the decision to have references to py3k scripts always contain a
    "3", I agree that "make fullinstall" is no longer appropriate.

    With r72723 and current py3k, however, there are still some issues.
    Compare ls -l bin from 2.6.2, 3.0.1, and current py3k:

    $ cd /Library/Frameworks/Python.framework/Versions
$ ls -l 2.6/bin
total 264
-rwxrwxr-x  1 root  admin    150 Apr 16 00:28 2to3*
lrwxr-xr-x  1 root  admin      7 May 21 23:57 idle@ -> idle2.6
-rwxrwxr-x  1 root  admin    138 Apr 16 00:28 idle2.6*
lrwxr-xr-x  1 root  admin      8 May 21 23:57 pydoc@ -> pydoc2.6
-rwxrwxr-x  1 root  admin    123 Apr 16 00:28 pydoc2.6*
lrwxr-xr-x  1 root  admin      9 May 21 23:57 python@ -> python2.6
lrwxr-xr-x  1 root  admin     16 May 21 23:57 python-config@ -> 
python2.6-config
-rwxrwxr-x  1 root  admin  33688 Apr 16 00:30 python2.6*
-rwxrwxr-x  1 root  admin   1463 Apr 16 00:29 python2.6-config*
lrwxr-xr-x  1 root  admin     10 May 21 23:57 pythonw@ -> pythonw2.6
-rwxrwxr-x  1 root  admin  33688 Apr 16 00:30 pythonw2.6*
lrwxr-xr-x  1 root  admin     11 May 21 23:57 smtpd.py@ -> smtpd2.6.py
-rwxrwxr-x  1 root  admin  18093 Apr 16 00:28 smtpd2.6.py*

$ ls -l 3.0/bin
total 248
-rwxrwxr-x  1 root  admin    150 Feb 14 10:04 2to3*
lrwxr-xr-x  1 root  admin      7 May 21 23:58 idle@ -> idle3.0
-rwxrwxr-x  1 root  admin    138 Feb 14 10:04 idle3.0*
lrwxr-xr-x  1 root  admin      8 May 21 23:58 pydoc@ -> pydoc3.0
-rwxrwxr-x  1 root  admin    123 Feb 14 10:04 pydoc3.0*
lrwxr-xr-x  1 root  admin      9 May 21 23:58 python@ -> python3.0
lrwxr-xr-x  1 root  admin     16 May 21 23:58 python-config@ -> 
python3.0-config
-rwxrwxr-x  1 root  admin  29560 Feb 14 10:05 python3.0*
-rwxrwxr-x  1 root  admin   1440 Feb 14 10:05 python3.0-config*
lrwxr-xr-x  1 root  admin     10 May 21 23:58 pythonw@ -> pythonw3.0
-rwxrwxr-x  1 root  admin  29560 Feb 14 10:05 pythonw3.0*
lrwxr-xr-x  1 root  admin     11 May 21 23:58 smtpd.py@ -> smtpd3.0.py
-rwxrwxr-x  1 root  admin  18119 Feb 14 10:04 smtpd3.0.py*

$ ls -l 3.1/bin
total 272
lrwxr-xr-x  1 root  admin      7 May 21 19:10 idle3@ -> idle3.1
-rwxrwxr-x  1 root  admin    138 May 21 18:51 idle3.1*
lrwxr-xr-x  1 root  admin      8 May 21 19:10 pydoc3@ -> pydoc3.1
-rwxrwxr-x  1 root  admin    123 May 21 18:51 pydoc3.1*
-rwxrwxr-x  1 root  admin  34220 May 21 18:51 python*
lrwxr-xr-x  1 root  admin     16 May 21 19:10 python-config@ -> 
python3.1-config
lrwxr-xr-x  1 root  admin      9 May 21 19:10 python3@ -> python3.1
lrwxr-xr-x  1 root  admin     16 May 21 19:10 python3-config@ -> 
python3.1-config
-rwxrwxr-x  1 root  admin  29560 May 21 18:51 python3.1*
-rwxrwxr-x  1 root  admin   1440 May 21 18:51 python3.1-config*
lrwxr-xr-x  1 root  admin     10 May 21 19:10 pythonw3@ -> pythonw3.1
-rwxrwxr-x  1 root  admin  29560 May 21 18:51 pythonw3.1*

    Issues:

    1. In py3k bin, there is a "python" binary rather than the symlink that
      was there before. That appears to be the unstripped binary of the
      interpreter (before it is stripped installed into the fw app bundle).
      Presumably the symlink install used to implicitly remove the binary; now
      an explicit rm is needed?

    2. There is still a symlink to python-config.

    3. There is no longer *any* 2to3 script, versioned or not. r71936
      (setup.py) is the culprit here (bpo-5756, which I'm reopening to ensure
      this issue is examined for all platforms). With regard to the OSX
      installer, since Tools/scripts isn't installed, there needs to be a
      script of some kind in bin. As discussed in bpo-5756, it should be
      decided how to resolve conflicts between a py2 2to3 and a py3 one.

    4. There is no longer any smtpd.py or smtpd3.x.py script/link installed,
      also due to r71936 (setup.py) and to r72723 (Mac/Makefile.in). I don't
      see this as a huge issue since I doubt that script is used much at all.
      But, at the least, a NEWS/What's New and/or README item about its
      removal in 3.1 is in order.

    @ned-deily
    Copy link
    Member Author

    Issues update:

    1. Benjamin fixed this in r72857.

    2. Also fixed in r72857.

    3. Fixed in r72866.

    4. open - all that is needed is to add a NEWS item about smtpd.py no
      longer being installed as script

    @ronaldoussoren
    Copy link
    Contributor

    You've got a point there.

    Benjamin: should the removal of smtpd.py from the list of installed
    scripts be listed in the NEWS file?

    @benjaminp
    Copy link
    Contributor

    2009/5/26 Ronald Oussoren <report@bugs.python.org>:

    Ronald Oussoren <ronaldoussoren@mac.com> added the comment:

    You've got a point there.

    Benjamin: should the removal of smtpd.py from the list of installed
    scripts be listed in the NEWS file?

    Yes, do you want to do that?

    @ronaldoussoren
    Copy link
    Contributor

    Sure. Done in r72948.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build OS-mac type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @benjaminp @ronaldoussoren @ned-deily