New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 263 Implementation #36217
Comments
The attached patch implements PEP-263. The following
|
Logged In: YES A note on the implementation strategy: it turned out that To solve this, I introduced encoding_decl pseudo node: it is |
Logged In: YES Thank you ! I'll add a note to the PEP about the way the first two lines |
Logged In: YES I've set the group to Python 2.3 so the priority has some I haven't accepted the PEP yet (although I expect I will), |
Logged In: YES Ok, I've had a look at the patch. It looks good except for the overly Even though there's a bit of code duplication, PyUnicode_DecodeUnicodeEscape(char*...)
and
PyUnicode_DecodeUnicodeEscapeFromUnicode(Py_UNICODE*...) This is easier to support and gives better You'll also need to include a name mangling |
Logged In: YES Changing the decoding functions will not result in one That seems quite unmaintainable to me: any change now needs |
Logged In: YES Version 2 of this patch implements revision 1.11 of the PEP |
Logged In: YES Apart from the codec changes, the patch looks ok. I would still like two APIs for the two different codec tasks, |
Logged In: YES This patch has been superceded by 534304. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: