Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding T_SIZET to structmember.h #49498

Closed
dalcinl mannequin opened this issue Feb 13, 2009 · 7 comments
Closed

Adding T_SIZET to structmember.h #49498

dalcinl mannequin opened this issue Feb 13, 2009 · 7 comments
Labels
3.9 only security fixes 3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@dalcinl
Copy link
Mannequin

dalcinl mannequin commented Feb 13, 2009

BPO 5248
Nosy @mdickinson, @pitrou, @meadori

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2009-02-13.15:42:10.212>
labels = ['interpreter-core', 'type-feature', '3.9', '3.10']
title = 'Adding T_SIZET to structmember.h'
updated_at = <Date 2020-11-07.01:08:17.230>
user = 'https://bugs.python.org/dalcinl'

bugs.python.org fields:

activity = <Date 2020-11-07.01:08:17.230>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2009-02-13.15:42:10.212>
creator = 'dalcinl'
dependencies = []
files = []
hgrepos = []
issue_num = 5248
keywords = []
message_count = 6.0
messages = ['81942', '81944', '81953', '81955', '81968', '222878']
nosy_count = 4.0
nosy_names = ['mark.dickinson', 'dalcinl', 'pitrou', 'meador.inge']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue5248'
versions = ['Python 3.9', 'Python 3.10']

@dalcinl
Copy link
Mannequin Author

dalcinl mannequin commented Feb 13, 2009

structmember.h lacks a 'T_SIZET' define in order to properly support
struct fields of type 'size_t' within PyMemberDef.

If this feature request is accepted, I can provide the patches.

For 2.7, It would be nice to do:

#define T_SIZET      20      /* size_t */

However, this value is already used in 3.0 for 'T_NONE'. Perhaps T_NONE
should be backported to 2.7?

To avoid future merge conflicts, I would vote for this definition:

#define T_SIZET      21      /* size_t */

@dalcinl dalcinl mannequin added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Feb 13, 2009
@pitrou
Copy link
Member

pitrou commented Feb 13, 2009

Do we really want size_t or rather Py_ssize_t?

@dalcinl
Copy link
Mannequin Author

dalcinl mannequin commented Feb 13, 2009

In 2.6 and 3.0, we already have 'Py_ssize_t', see 'T_PYSSIZET'
definition on Include/structmember.h. I'm asking for 'size_t' support.

@pitrou
Copy link
Member

pitrou commented Feb 13, 2009

In 2.6 and 3.0, we already have 'Py_ssize_t', see 'T_PYSSIZET'
definition on Include/structmember.h. I'm asking for 'size_t' support.

Oops, sorry for the noise then.

@mdickinson
Copy link
Member

If this feature request is accepted, I can provide the patches.

Well, that's not how things work: there isn't really a mechanism for
'accepting' a feature request. Even if there were, that wouldn't
guarantee acceptance of a patch for that feature request.

For what it's worth, I think that there's a good chance that a well-
written patch for this feature request would be accepted: it seems like a
potentially useful addition, and I can't immediately see why it would be
objectionable or controversial, but I haven't looked at the issue very
closely. I'd suggest that provided you don't get any negative feedback
from the python-dev thread or from the comments in this issue in the next
few days, then it's probably worth working on a patch.

I'd also be happy to review such a patch if/when it's ready.

@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Jul 12, 2014

msg81942 states "structmember.h lacks a 'T_SIZET' define in order to properly support struct fields of type 'size_t' within PyMemberDef." As we have managed without this feature for the last five years do we really need it now? What do we gain by implementing this?

@iritkatriel iritkatriel added 3.9 only security fixes 3.10 only security fixes labels Nov 7, 2020
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@iritkatriel
Copy link
Member

This has been idle for well over a decade. Closing due to lack of interest. It can be reopened (or a new issue created) if anyone needs it.

@iritkatriel iritkatriel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 only security fixes 3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants