Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X IDLE.app and bin/idle: missing/extra menu options #49444

Closed
ned-deily opened this issue Feb 10, 2009 · 3 comments
Closed

OS X IDLE.app and bin/idle: missing/extra menu options #49444

ned-deily opened this issue Feb 10, 2009 · 3 comments
Labels
OS-mac topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@ned-deily
Copy link
Member

BPO 5194
Nosy @ronaldoussoren, @ned-deily
Files
  • patch-nad0014-trunk-26.txt
  • patch-nad0014-py3k-30.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2009-03-04.21:36:05.197>
created_at = <Date 2009-02-10.02:55:05.997>
labels = ['OS-mac', 'expert-IDLE', 'type-bug']
title = 'OS X IDLE.app and bin/idle: missing/extra menu options'
updated_at = <Date 2009-03-04.21:36:05.196>
user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2009-03-04.21:36:05.196>
actor = 'ronaldoussoren'
assignee = 'none'
closed = True
closed_date = <Date 2009-03-04.21:36:05.197>
closer = 'ronaldoussoren'
components = ['IDLE', 'macOS']
creation = <Date 2009-02-10.02:55:05.997>
creator = 'ned.deily'
dependencies = []
files = ['13001', '13002']
hgrepos = []
issue_num = 5194
keywords = []
message_count = 3.0
messages = ['81525', '81769', '83140']
nosy_count = 2.0
nosy_names = ['ronaldoussoren', 'ned.deily']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue5194'
versions = ['Python 2.6', 'Python 3.0', 'Python 3.1', 'Python 2.7']
    @ned-deily
    Copy link
    Member Author

    IDLE is supposed to have various menu customizations when running on OS
    X. But currently they do not all work and the menus vary if IDLE is
    launched via IDLE.app versus via command line bin/idle. The most
    noticeable issue is the lack of a Preferences menu item in IDLE.app to
    access the IDLE configuration settings.

    ANALYSIS There are inconsistent OS X execution checks scattered
    throughout idlelib. Also, the bootstrap mechanism
    for IDLE.app causes sys.executable to be set incorrectly.
    Most importantly, idlemain imports idlelib before it
    has fixed up the execution environment. This can cause
    the menu fixup in idlelib.Bindings to be skipped.

    SOLUTION Change idlemain to set up the execution environment
    consistently and defer idlelib imports until it has done so.
    Modify several OS X checks in idlelib for consistency.

    APPLIES py3k, 3.0 -> patch-nad0014-py3k-30.txt
    trunk, 2.6 -> patch-nad0014-trunk-26.txt

    DELETE Mac/IDLE/idlemain.py (py3k and 3.0 only!)

    NOTE In 3.x idlemain.py was copied down into the app bundle:
    2.x -> Mac/IDLE/idlemain.py
    3.x -> Mac/IDLE/IDLE.app/Contents/Resources/idlemain.py
    3.x -> Mac/IDLE/idlemain.py -> unused / delete
    so there are two versions of this patch.
    However, the 2.x location was not deleted in 3.x svn
    so there are two identical files in 3.x prior to this
    patch.

    @ned-deily ned-deily added topic-IDLE OS-mac type-bug An unexpected behavior, bug, or error labels Feb 10, 2009
    @ronaldoussoren
    Copy link
    Contributor

    I've fixed this for 3.1 in r69532. Fixed for 3.0 in r69533 (backport of
    the other patch).

    The actual checkin is based on "patch-nad0014-py3k-30.txt", but with some
    minor tweaks (I use "idlelib.macosxSupport.runningAsOSXApp" throughout,
    instead of sometimes doing the same check by hand).

    @ronaldoussoren
    Copy link
    Contributor

    I've applied a cleaned up version of patch-nad0014-trunk-26.txt to the
    trunk and 2.6 branch. This completely fixes this issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    OS-mac topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ronaldoussoren @ned-deily