Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating (and removing) "globalcall", "merge" and "globaleval" #49386

Closed
gpolo mannequin opened this issue Feb 3, 2009 · 11 comments
Closed

Deprecating (and removing) "globalcall", "merge" and "globaleval" #49386

gpolo mannequin opened this issue Feb 3, 2009 · 11 comments
Assignees
@asvetlov
Labels
topic-tkinter type-feature A feature request or enhancement

Comments

@gpolo
Copy link
Mannequin

gpolo mannequin commented Feb 3, 2009

BPO 5136
Nosy @merwok, @asvetlov
Files
  • issue5136.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/asvetlov'
closed_at = <Date 2012-03-31.16:41:23.592>
created_at = <Date 2009-02-03.01:04:46.825>
labels = ['type-feature', 'expert-tkinter']
title = 'Deprecating (and removing) "globalcall", "merge" and "globaleval"'
updated_at = <Date 2012-03-31.16:42:11.442>
user = 'https://bugs.python.org/gpolo'

    bugs.python.org fields:

    activity = <Date 2012-03-31.16:42:11.442>
actor = 'asvetlov'
assignee = 'asvetlov'
closed = True
closed_date = <Date 2012-03-31.16:41:23.592>
closer = 'asvetlov'
components = ['Tkinter']
creation = <Date 2009-02-03.01:04:46.825>
creator = 'gpolo'
dependencies = []
files = ['25082']
hgrepos = []
issue_num = 5136
keywords = ['patch']
message_count = 11.0
messages = ['81021', '108190', '111723', '111784', '156543', '157180', '157197', '157198', '157202', '157204', '157205']
nosy_count = 5.0
nosy_names = ['gpolo', 'eric.araujo', 'asvetlov', 'BreamoreBoy', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue5136'
versions = ['Python 3.3']
    @gpolo
    Copy link
    Mannequin Author

    gpolo mannequin commented Feb 3, 2009

    Hi, I'm going to try explaining in short why I think each of these
    functions in _tkinter could be marked as deprecated and then removed on
    2.8 (if it is decided to do it) and 3.1.

    globalcall: It is not used anywhere in tkinter. It was abandoned, and
    doesn't work in the same situations where "call" would work (with
    threads). It doesn't care about converting the result to a proper python
    object -- it is always a string (another result of the abandonment).
    "call" already works in the Tcl global space, because it needs to do so
    (see bpo-1581476). Even tcl 8.2 says Tcl_GlobalEval (the root of
    "globalcall") is old and deprecated.

    merge: globalcall depends on merge, but removing globalcall makes merge
    obsolete. It is not used by tkinter either. Searching for "tk.merge" on
    google codesearch returns a single result dating back python 1.1!

    globaleval: Uses Tcl_GlobalEval too. I haven't seen it being used,
    instead I always see eval being used.

    @gpolo gpolo mannequin added the topic-tkinter label Feb 3, 2009
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jun 19, 2010

    From the recent large thread on c.l.py regarding Python GUIs I understand that the author of this issue Guilherme Polo has done a massive amount of work on Tkinter. Would it therefore be possible for him to give an update as to whether this issue can be closed as out of date, already actioned but not recorded, or whatever? Thanks.

    There are several other issues raised by Guilherme Polo regarding Tkinter, sorry I'm too lazy to repeat this comment on all of them.

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jul 27, 2010

    Is it still possible to get this into 3.2 and have them remove in 3.3?

    @BreamoreBoy BreamoreBoy mannequin added the type-feature A feature request or enhancement label Jul 27, 2010
    @merwok
    Copy link
    Member

    merwok commented Jul 28, 2010

    Guilherme, I suggest you ask about that on pydev and/or idle-dev, or just commit the addition of PendingDeprecationWarnings and wait for reactions.

    @merwok
    Copy link
    Member

    merwok commented Mar 22, 2012

    Andrew, you can take over this issue if you want. As you’ve discovered with bpo-3035, our deprecation process is a bit unclear (this was discussed on python-dev a few months ago), so using PendingDeprecationWarning vs. DeprecationWarning is a judgment call.

    @asvetlov
    Copy link
    Contributor

    Will do.

    @asvetlov asvetlov self-assigned this Mar 31, 2012
    @asvetlov
    Copy link
    Contributor

    Attaching the patch to make depredations.

    @merwok
    Copy link
    Member

    merwok commented Mar 31, 2012

    LGTM (looks good to me). In your NEWS entry, you don’t have to copy the whole explanation, just say something like “deprecated old, unused functions” and interested people will be able to come here read the details. In your commit message, be sure to say that the patch does not add deprecation notices in the doc because the functions are undocumented.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 31, 2012

    New changeset 6023d73c6f87 by Andrew Svetlov in branch 'default':
    fix issue bpo-5136: deprecate old unused functions from tkinter.
    http://hg.python.org/cpython/rev/6023d73c6f87

    @asvetlov
    Copy link
    Contributor

    Pushed deprecation warnings into default branch.
    bpo-14446 updated to add those function to remove list for 3.4 release.

    @asvetlov
    Copy link
    Contributor

    Thanks to Guilherme Polo for idea and to Éric Araujo for review.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @asvetlov asvetlov

    Labels
    topic-tkinter type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @asvetlov @merwok