New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bdist_wininst fails on py3k #49326
Comments
bdist_wininst installers created by py3k fail due to PySys_SetArgv and The patch is against the svn trunk as currently Python 2.x and 3.x share The patch does not include the 2 new stub executables required |
Is it really useful to be have the same stub for 2.x and 3.x? I think it |
Good question! I'm not really aware of the complexities involved in
merging between the various branches, but given the fairly trivial
nature of the patch I figured there were potential advantages in both
identical source and stubs. I'm happy to work the patch into either
#ifdef based (ie, identical source, different stubs), or "unconditional"
(both source and stubs different) if you prefer - and if so, which of
those 2 do you prefer? On a related note, its obviously true that the same final installer will |
It's still possible to merge changes reasonably even if the "target" |
Attaching an updated patch against the py3k branch which makes no |
This patch is fine, please apply. I wish it wouldn't be necessary to widen char*, but start off with |
Checked into py3k as r6998; merged to release30-maint as 69099. I hope |
If you ask whether checking into py3k was the right thing: yes, it was. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: