Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE documentation for Unix obsolete/incorrect #49316

Closed
stevendaprano opened this issue Jan 26, 2009 · 30 comments
Closed

IDLE documentation for Unix obsolete/incorrect #49316

stevendaprano opened this issue Jan 26, 2009 · 30 comments
Labels
docs Documentation in the Doc dir easy topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@stevendaprano
Copy link
Member

BPO 5066
Nosy @birkenfeld, @terryjreedy, @orsenthil, @devdanzin, @ezio-melotti, @serwy, @merwok, @stevendaprano, @asvetlov, @rovitotv, @zware
Files
  • issue5066.patch: update IDLE menu option descriptions
  • 5066IDLEocumentationforUnixObsoleteIncorrect.patch
  • 5066IDLEocumentationforUnixObsoleteIncorrectVersion2.patch
  • 5066IDLEocumentationforUnixObsoleteIncorrectVersion3.patch
  • 5066IDLEocumentationforUnixObsoleteIncorrectVersion4.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-01-14.17:28:16.953>
    created_at = <Date 2009-01-26.03:56:57.057>
    labels = ['easy', 'expert-IDLE', 'type-bug', 'docs']
    title = 'IDLE documentation for Unix obsolete/incorrect'
    updated_at = <Date 2013-01-14.17:28:16.951>
    user = 'https://github.com/stevendaprano'

    bugs.python.org fields:

    activity = <Date 2013-01-14.17:28:16.951>
    actor = 'asvetlov'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2013-01-14.17:28:16.953>
    closer = 'asvetlov'
    components = ['Documentation', 'IDLE']
    creation = <Date 2009-01-26.03:56:57.057>
    creator = 'steven.daprano'
    dependencies = []
    files = ['19535', '28138', '28141', '28626', '28643']
    hgrepos = []
    issue_num = 5066
    keywords = ['patch', 'easy']
    message_count = 30.0
    messages = ['80562', '80595', '81200', '81227', '81268', '86622', '120698', '121743', '176326', '176462', '176463', '176503', '176504', '179033', '179059', '179072', '179266', '179279', '179280', '179312', '179313', '179348', '179359', '179360', '179363', '179406', '179409', '179446', '179957', '179958']
    nosy_count = 16.0
    nosy_names = ['georg.brandl', 'terry.reedy', 'orsenthil', 'ajaksu2', 'gpolo', 'ezio.melotti', 'roger.serwy', 'eric.araujo', 'steven.daprano', 'asvetlov', 'jesstess', 'docs@python', 'Todd.Rovito', 'ramiroluz', 'python-dev', 'zach.ware']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue5066'
    versions = ['Python 3.4']

    @stevendaprano
    Copy link
    Member Author

    Documentation for IDLE states:

    Starting IDLE on UNIX 
    On Unix, just type "idle" at a command prompt. This should bring
    up a Window similar to the one above. (If it doesn't, look for
    the "idle" script in the [Tools/idle](https://github.com/python/cpython/blob/main/Tools/idle) directory in the Python source
    distribution.)
    

    http://www.python.org/idle/doc/idlemain.html

    I believe that is obsolete, I cannot see a Tools/idle directory in
    either 2.5 or 2.6. Perhaps better instructions might be:

    (If it doesn't, run "python LOC/idlelib/idle.py" where LOC 
    is the location of your Python source distribution, usually 
    /usr/lib/python*.)
    

    or similar.

    @stevendaprano stevendaprano added docs Documentation in the Doc dir topic-IDLE labels Jan 26, 2009
    @terryjreedy
    Copy link
    Member

    LOL. That doc was apparently last revised in 2000 for the IDLE released
    with 1.5.2 (see screenshot). Other needed updates I see are: 'Shell'
    and 'Options' have been added to the menu line; we now have unicode
    text; screenshots look different (and nicer) on newer Tk on WinXP and
    could/should be redone.

    If it were decided to update this and add it to the doc package, I would
    help in some way.

    @birkenfeld
    Copy link
    Member

    Well, having nice full docs for IDLE would be nice, but I won't do
    anything on this matter except committing a full patch :)

    @birkenfeld birkenfeld removed their assignment Feb 5, 2009
    @terryjreedy
    Copy link
    Member

    Is there an HTML to acceptable RST converter?

    @birkenfeld
    Copy link
    Member

    I don't know any. But since rst is so lightweight, it is usually not too
    much of a pain to just copy the text from the browser and reintroduce
    formatting because you're likely to have to go over and edit the whole
    content anyway.

    @devdanzin
    Copy link
    Mannequin

    devdanzin mannequin commented Apr 26, 2009

    This looks like a perfect match for GHOP.

    @devdanzin devdanzin mannequin added easy type-bug An unexpected behavior, bug, or error labels Apr 26, 2009
    @jesstess
    Copy link
    Member

    jesstess commented Nov 8, 2010

    Attached is a patch updating the IDLE web documentation as well as the help file displayed when you click the Help -> Idle Help menu item in IDLE. It looks like the IDLE web documentation was lifted directly from the help file at some point and they have gotten out of sync.

    The section of the document describing starting IDLE was updated in March of 2009, so I've left that alone. I've updated the Menu option descriptions in both files, including: adding missing items, making the help file and web document descriptions the same, and using a consistent format.

    The patch is against release27-maint.

    @ramiroluz
    Copy link
    Mannequin

    ramiroluz mannequin commented Nov 20, 2010

    I reviewed the texts, applied the patches, ran idle, edited Demo/classes/Dates.py run module inside Idle. Generated the docs inside Doc, with make html and reviewed the IDLE doc in ~/python/py3k/Doc/build/html/library/idle.html?highlight=idle

    Only in the 3.2 tree.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Nov 25, 2012

    This is a good patch but it is rather out of date and won't apply. I will patch the patch and maybe somebody can apply it this time. Expect a new patch by 11/26/2012.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Nov 27, 2012

    This patch is an extensive refactoring of help.txt and idle.rst. The first thing I did was merge bpo-5066.patch from jesstess into the current idle.rst file, because the original patch from jesstess was so old it had to be merged by hand into the 3.4 source code. Then I compared what the merge document said with the actual menus of IDLE and made several corrections because of missing menu options. Finally I refactored the help.txt based on idle.rst and created the resulting patch. Several capitalization's were fixed along with many inconsistencies between the two files.

    I have not tested on 2.7 only 3.4. My plan is to test with 2.7 and create another patch by end of the week 12/2/2012.

    @serwy
    Copy link
    Mannequin

    serwy mannequin commented Nov 27, 2012

    The original help.txt and the patched version still mixes tabs and spaces. This is a minor point, but perhaps all the tabs should be expanded.

    Also, the section on running IDLE without a subprocess should not be removed until version 3.5. See bpo-16123.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Nov 28, 2012

    Version 2 of the patch change include:
    -help.txt removed all tabs and replaced with spaces, as suggested by Roger
    -help.txt re-inserted the section on running IDLE without a subprocess as suggested by Roger
    -Added a note on line 162 (idle.rst) about how the Python Community standard is to use spaces and not tabs as suggested by ezio
    -Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine on my computer without the spaces but I think ezio is correct spaces should be present so I added them
    -Line 354 (idle.rst): are restricted to four spaces due to TCL/Tk issues.)s/issues/limitations/ so I replaced issues with limitations

    Thanks for the feedback Roger and ezio!

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Nov 28, 2012

    For version 2 of the patch
    -Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine on my computer without the spaces but I think ezio is correct spaces should be present so I added them

    SHOULD BE
    -Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine on my computer without the empty line between entries but I think ezio is correct empty lines should be present so I added empty lines just to be safe

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Jan 4, 2013

    A "ping" on this bug since it has not had any forward movement. Can somebody please review and or commit? Thanks.

    @zware
    Copy link
    Member

    zware commented Jan 4, 2013

    Hi Todd, I can't commit, but I have a review in the works for you.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Jan 4, 2013

    Thanks much appreciated!

    Sent from my iPhone

    On Jan 4, 2013, at 1:07 PM, Zachary Ware <report@bugs.python.org> wrote:

    Zachary Ware added the comment:

    Hi Todd, I can't commit, but I have a review in the works for you.

    ----------
    nosy: +zach.ware


    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue5066\>


    @zware
    Copy link
    Member

    zware commented Jan 7, 2013

    I wonder, is there any really good reason to keep a separate Lib/idlelib/help.txt, or can Doc/library/idle.rst be used for its purpose (with or without a small amount of processing to, for instance, remove comments and extra backslashes)? Both have most of the same information, and reST is designed to be readable anyway, so I don't see much point in keeping them separate.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Jan 7, 2013

    Zachary,
    I like your idea about joining idle.rst with help.txt but I think that should be covered under a separate bug issue. The way I see it this bug is about fixing the current documentation. So I suggest you open up a new issue and get people's take on it. I think a parser could be run at installation to convert idle.rst to help.txt or maybe IDLE could be modified to simply render idle.rst correctly. I am not sure what the best approach will be.

    PS Thanks for the review I should have your suggested changes integrating into a new patch today.

    @zware
    Copy link
    Member

    zware commented Jan 7, 2013

    Right you are, Todd; I'll get another issue opened for that soon.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Jan 8, 2013

    Zachary,
    Thanks for your excellent review!!!! Your feedback was very helpful for making the patch even better.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Jan 8, 2013

    Based on Zachary's comments I have uploaded a new version of the patch which is version 3.

    @merwok
    Copy link
    Member

    merwok commented Jan 8, 2013

    Idle needs to find its text help files at runtime, so they are installed as data alongside with the code. The rst doc files however can be installed anywhere or not installed at all, so we can’t change Idle to look for them.

    An alternate idea to avoid duplication could be to copy the rst file to the code directory at build time.

    @orsenthil
    Copy link
    Member

    Regardless of the topic of merge, the suggested improvements for both idle.rst and help.txt are great! Thanks for working the patch, Todd.
    I am +1 with the changes. If no else has any comments, I can go ahead with committing this.

    @zware
    Copy link
    Member

    zware commented Jan 8, 2013

    I'd like to see Éric, Ezio, and my comments on v3 in Rietveld addressed, but after that I'm good with it :)

    @zware
    Copy link
    Member

    zware commented Jan 8, 2013

    bpo-16893 has been filed to deal with the idea of merging the files.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Jan 9, 2013

    Thanks Senthil but I don't deserve all the credit this issue is a team effort with lots of help from Zach, Éric, and Ezio. All of which have improved the patch's quality a great deal. Hopefully we can address the issues then let you make the commit soon.

    @rovitotv
    Copy link
    Mannequin

    rovitotv mannequin commented Jan 9, 2013

    I took all the comments and created a new patch version 4 which should address all the issues. Thanks for the excellent review and support from everybody. I think this patch is a much higher quality now.

    @zware
    Copy link
    Member

    zware commented Jan 9, 2013

    Version 4 looks good to me!

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 14, 2013

    New changeset d1ef91025d70 by Andrew Svetlov in branch 'default':
    Issue bpo-5066: Update IDLE docs
    http://hg.python.org/cpython/rev/d1ef91025d70

    @asvetlov
    Copy link
    Contributor

    Pushed. Thanks.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir easy topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    8 participants