Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark distutils to stay compatible with 2.3 #49302

Closed
akitada mannequin opened this issue Jan 25, 2009 · 9 comments
Closed

Mark distutils to stay compatible with 2.3 #49302

akitada mannequin opened this issue Jan 25, 2009 · 9 comments
Assignees
@tarekziade
Labels
stdlib Python modules in the Lib dir

Comments

@akitada
Copy link
Mannequin

akitada mannequin commented Jan 25, 2009

BPO 5052
Nosy @malemburg, @tiran, @tarekziade, @akitada
Files
  • 2.3.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tarekziade'
closed_at = <Date 2009-02-27.13:08:15.102>
created_at = <Date 2009-01-25.13:18:36.937>
labels = ['library']
title = 'Mark distutils to stay compatible with 2.3'
updated_at = <Date 2009-02-27.13:08:15.101>
user = 'https://github.com/akitada'

    bugs.python.org fields:

    activity = <Date 2009-02-27.13:08:15.101>
actor = 'tarek'
assignee = 'tarek'
closed = True
closed_date = <Date 2009-02-27.13:08:15.102>
closer = 'tarek'
components = ['Distutils']
creation = <Date 2009-01-25.13:18:36.937>
creator = 'akitada'
dependencies = []
files = ['13197']
hgrepos = []
issue_num = 5052
keywords = ['patch']
message_count = 9.0
messages = ['80507', '80508', '80545', '80546', '80547', '80551', '80965', '82794', '82831']
nosy_count = 4.0
nosy_names = ['lemburg', 'christian.heimes', 'tarek', 'akitada']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue5052'
versions = ['Python 3.1', 'Python 2.7']
    @akitada
    Copy link
    Mannequin Author

    akitada mannequin commented Jan 25, 2009

    In distutils package, there are many files that saying
    "This module should be kept compatible with Python 2.1."

    According to Tarek Ziadé, this is not valid statement anymore.

    @akitada akitada mannequin added the stdlib Python modules in the Lib dir label Jan 25, 2009
    @akitada
    Copy link
    Mannequin Author

    akitada mannequin commented Jan 25, 2009

    If PEP-291 is still valid, distutils needs "only remain compatible with
    the version of Python it is distributed with."

    @tarekziade tarekziade mannequin self-assigned this Jan 25, 2009
    @tarekziade
    Copy link
    Mannequin

    tarekziade mannequin commented Jan 25, 2009

    done in r68943

    @tarekziade tarekziade mannequin closed this as completed Jan 25, 2009
    @malemburg
    Copy link
    Member

    Note that distutils was removed from PEP-291 in r1982 "After some
    discussion at the distutils sprint at PyCon 2005".

    This was not discussed on the distutils mailing list at the time which I
    regard as not in line with the way Python or distutils is developed.

    While we likely don't need Python 2.1 compatibility anymore, Python 2.3
    is still in active use, so keeping distutils Python 2.3 compatible would
    allow package authors to use a single distutils version (the Python 2.6
    one) to cover the Python releases 2.3 - 2.6.

    @tarekziade
    Copy link
    Mannequin

    tarekziade mannequin commented Jan 25, 2009

    Ok, I will rewrite the top README file to explain this (and PEP-291 as
    well) and keep the Python 2.3 compatibility in the whole package.

    @tarekziade tarekziade mannequin reopened this Jan 25, 2009
    @tarekziade tarekziade mannequin changed the title "This module should be kept compatible with Python 2.1." in distutils code Mark distutils to stay compatible with 2.3 Jan 25, 2009
    @akitada
    Copy link
    Mannequin Author

    akitada mannequin commented Jan 26, 2009

    Is there any PEP describing we have to keep compatibility with 2.3
    release? I'm not against the idea but just curious.

    @malemburg
    Copy link
    Member

    Some more explanation for why keeping distutils Python 2.3 compatible is
    desirable:

    distutils was removed from the PEP without any public discussion outside
    a sprint at PyCon and the reasons given for it did not take into account
    that people will want to use a single distutils version (that of the
    lastest released Python version) to build packages for multiple Python
    versions.

    distutils in Python 2.6 no longer works with Python 2.1, but it still
    does mostly with Python 2.3 and I would prefer to have to use that
    version as minimum required.

    Over the years I've always tried to rework any changes that were done
    which did not meet that requirement and only left non-Python 2.3 code
    in place that was not relevant for that version anyway, e.g. the
    new MSVC code for Python 2.6.

    Please also note that distutils is not a performance critical piece of
    software. Making it more developer friendly to extending via
    sub-classing and more user friendly by adding more support for platform
    specific installer format is much more important than using the latest
    and greatest tricks in Python.

    With Python 2.7 released, we can then move on to Python 2.4
    compatibility and so on.

    @tarekziade
    Copy link
    Mannequin

    tarekziade mannequin commented Feb 26, 2009

    ok the current trunk won't run even under 2.5...

    I will make two small changes:

    • use md5 module of haslib is not found
    • make the smallest possible change for site.USER_BASE
      and site.USER_SITE usage

    @tarekziade
    Copy link
    Mannequin

    tarekziade mannequin commented Feb 27, 2009

    And we're back in PEP-291 !

    see r70019, r70017 and r70021

    @tarekziade tarekziade mannequin closed this as completed Feb 27, 2009
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tarekziade tarekziade

    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @malemburg