Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in importlib #49243

Closed
pitrou opened this issue Jan 19, 2009 · 2 comments
Closed

Typo in importlib #49243

pitrou opened this issue Jan 19, 2009 · 2 comments
Assignees
@brettcannon
Labels
type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Jan 19, 2009

BPO 4993
Nosy @brettcannon, @pitrou

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2009-01-19.06:56:48.543>
created_at = <Date 2009-01-19.00:34:42.197>
labels = ['type-bug']
title = 'Typo in importlib'
updated_at = <Date 2009-01-19.06:56:48.527>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2009-01-19.06:56:48.527>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2009-01-19.06:56:48.543>
closer = 'brett.cannon'
components = []
creation = <Date 2009-01-19.00:34:42.197>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 4993
keywords = []
message_count = 2.0
messages = ['80139', '80147']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'pitrou']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue4993'
versions = ['Python 3.1']
@pitrou
Copy link
Member Author

pitrou commented Jan 19, 2009

In importlib/_bootstrap.py, line 435 reads:

        with closing(_fileio_FileIO(source_path, 'r')) as file:

which whould probably be:

        with closing(_fileio._FileIO(source_path, 'r')) as file:

@pitrou pitrou added the type-bug An unexpected behavior, bug, or error label Jan 19, 2009
@brettcannon
Copy link
Member

Yeah, that code has not been tested yet as that is farther down the todo
list. Thanks for the catch!

Fixed in r68761.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @pitrou