Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lib/test/test__locale uses is to compare strings #49196

Closed
fijal opened this issue Jan 14, 2009 · 3 comments
Closed

Lib/test/test__locale uses is to compare strings #49196

fijal opened this issue Jan 14, 2009 · 3 comments
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir

Comments

@fijal
Copy link

fijal commented Jan 14, 2009

BPO 4946
Nosy @benjaminp
Files
  • out.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2009-01-16.02:55:39.492>
created_at = <Date 2009-01-14.10:54:25.901>
labels = ['tests', 'library']
title = 'Lib/test/test__locale uses is to compare strings'
updated_at = <Date 2009-01-16.02:55:39.490>
user = 'https://bugs.python.org/fijal'

    bugs.python.org fields:

    activity = <Date 2009-01-16.02:55:39.490>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2009-01-16.02:55:39.492>
closer = 'benjamin.peterson'
components = ['Library (Lib)', 'Tests']
creation = <Date 2009-01-14.10:54:25.901>
creator = 'fijal'
dependencies = []
files = ['12740']
hgrepos = []
issue_num = 4946
keywords = ['patch']
message_count = 3.0
messages = ['79846', '79879', '79929']
nosy_count = 3.0
nosy_names = ['ggenellina', 'fijal', 'benjamin.peterson']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue4946'
versions = ['Python 2.7']
    @fijal
    Copy link
    Author

    fijal commented Jan 14, 2009

    this is at least a bad practice. It also might break silently at any point.

    @fijal fijal added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir labels Jan 14, 2009
    @ggenellina
    Copy link
    Mannequin

    ggenellina mannequin commented Jan 14, 2009

    Yes, checking object identity is wrong in this case. Your patch looks
    fine to me.

    I've found several other "is" comparisons that should not be there --
    working on a patch right now.

    @benjaminp
    Copy link
    Contributor

    Fixed in r68628.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @fijal @benjaminp