Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_io is broken on UCS4 #49166

Closed
benjaminp opened this issue Jan 11, 2009 · 7 comments
Closed

test_io is broken on UCS4 #49166

benjaminp opened this issue Jan 11, 2009 · 7 comments
Assignees
@pitrou
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-bug An unexpected behavior, bug, or error

Comments

@benjaminp
Copy link
Contributor

BPO 4916
Nosy @pitrou, @benjaminp
Files
  • issue4916.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pitrou'
closed_at = <Date 2009-01-11.23:58:15.351>
created_at = <Date 2009-01-11.21:53:45.432>
labels = ['interpreter-core', 'type-bug', 'release-blocker']
title = 'test_io is broken on UCS4'
updated_at = <Date 2009-01-12.00:13:54.809>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2009-01-12.00:13:54.809>
actor = 'benjamin.peterson'
assignee = 'pitrou'
closed = True
closed_date = <Date 2009-01-11.23:58:15.351>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2009-01-11.21:53:45.432>
creator = 'benjamin.peterson'
dependencies = []
files = ['12691']
hgrepos = []
issue_num = 4916
keywords = ['patch']
message_count = 7.0
messages = ['79630', '79632', '79633', '79634', '79635', '79637', '79638']
nosy_count = 2.0
nosy_names = ['pitrou', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue4916'
versions = ['Python 3.1']
    @benjaminp
    Copy link
    Contributor Author

    ======================================================================
    FAIL: testEncodedWrites (test.test_io.TextIOWrapperTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/temp/python/py3k/Lib/test/test_io.py", line 1082, in
testEncodedWrites
    self.assertEquals(f.read(), data * 2)
AssertionError:
'\U00310000\U00320000\U00330000\U00340000\U00350000\U00360000\U00370000\U00380000\U00390000\U00300000\U00310000\U00320000\U00330000\U00340000\U00350000\U00360000\U00370000\U0038000090'
!= '12345678901234567890'

    ======================================================================
    FAIL: testNewlines (test.test_io.TextIOWrapperTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/temp/python/py3k/Lib/test/test_io.py", line 874, in testNewlines
    self.assertEquals(got_line, exp_line)
AssertionError: '\U00750000\U006e0000\U00690000\U00780000\n' != 'unix\n'

    ======================================================================
    FAIL: test_newline_decoder (test.test_io.TextIOWrapperTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/temp/python/py3k/Lib/test/test_io.py", line 1275, in
test_newline_decoder
    self.check_newline_decoder(decoder, enc)
  File "/temp/python/py3k/Lib/test/test_io.py", line 1263, in
check_newline_decoder
    self.assertEquals(decoder.decode("abc".encode(encoding)), "abc")
AssertionError: '\U00610000\U00620000c' != 'abc'

    @benjaminp benjaminp added release-blocker interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Jan 11, 2009
    @pitrou
    Copy link
    Member

    pitrou commented Jan 11, 2009

    Ouch. What platform is this on?

    @benjaminp
    Copy link
    Contributor Author

    MacOS 10.4 PPC

    @pitrou
    Copy link
    Member

    pitrou commented Jan 11, 2009

    This is because of the new utf16 decoding code. I'll post a patch soon.

    @pitrou pitrou self-assigned this Jan 11, 2009
    @pitrou
    Copy link
    Member

    pitrou commented Jan 11, 2009

    Can you try with this one?

    PS: do we have a buildbot with such a configuration?

    @pitrou
    Copy link
    Member

    pitrou commented Jan 11, 2009

    Benjamin confirmed to me that the patch is ok, committing.

    @pitrou pitrou closed this as completed Jan 11, 2009
    @benjaminp
    Copy link
    Contributor Author

    In r68537.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @pitrou pitrou

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @pitrou