Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for thread-support in md5module.c #49068

Closed
ebfe mannequin opened this issue Jan 3, 2009 · 7 comments
Closed

Patch for thread-support in md5module.c #49068

ebfe mannequin opened this issue Jan 3, 2009 · 7 comments
Labels
extension-modules C modules in the Modules dir pending The issue will be closed if no feedback is provided performance Performance or resource usage

Comments

@ebfe
Copy link
Mannequin

ebfe mannequin commented Jan 3, 2009

BPO 4818
Nosy @loewis, @gpshead, @jcea, @tiran
Files
  • md5module_small_locks-2.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2009-01-03.11:23:59.564>
labels = ['extension-modules', 'performance']
title = 'Patch for thread-support in md5module.c'
updated_at = <Date 2012-10-06.23:44:01.385>
user = 'https://bugs.python.org/ebfe'

    bugs.python.org fields:

    activity = <Date 2012-10-06.23:44:01.385>
actor = 'christian.heimes'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2009-01-03.11:23:59.564>
creator = 'ebfe'
dependencies = []
files = ['12568']
hgrepos = []
issue_num = 4818
keywords = ['patch']
message_count = 5.0
messages = ['78947', '78950', '78954', '78963', '81727']
nosy_count = 5.0
nosy_names = ['loewis', 'gregory.p.smith', 'jcea', 'christian.heimes', 'ebfe']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue4818'
versions = ['Python 3.4']
    @ebfe
    Copy link
    Mannequin Author

    ebfe mannequin commented Jan 3, 2009

    Here is another patch, this time for the fallback-md5-module. I know
    that situations are rare where openssl is not present but threading is.
    However they might occur out there and the md5module needed some love
    anyway:

    • The MD5 class from the fallback module can now also use threads with
      'small locks'
    • The behaviour regarding unicode data input is now consistent as to
      what the openssl-driven classes do.
    • Some code cleanup.

    I might act on the sha modules as way the next days. sha256.c still
    accepts 's#'...

    Also see issue bpo-4751

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jan 3, 2009

    ebfe, please identify yourself with a real name; please also sign a
    contributor form.

    @ebfe
    Copy link
    Mannequin Author

    ebfe mannequin commented Jan 3, 2009

    Sent the form by fax

    @ebfe
    Copy link
    Mannequin Author

    ebfe mannequin commented Jan 3, 2009

    fixed naming, lock get's tried before releasing the gil to wait for it

    @gpshead
    Copy link
    Member

    gpshead commented Feb 12, 2009

    fyi - I took care of the unicode data acceptance issue for all hashlib
    related modules in the py3k branch in r69524.

    @tiran tiran added extension-modules C modules in the Modules dir performance Performance or resource usage labels Oct 6, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @iritkatriel
    Copy link
    Member

    This seems to have been abandoned over a decade ago. Is there any point leaving this issue open?

    @iritkatriel iritkatriel added the pending The issue will be closed if no feedback is provided label Aug 23, 2022
    @tiran
    Copy link
    Member

    tiran commented Aug 23, 2022

    nope

    @tiran tiran closed this as completed Aug 23, 2022
    @tiran tiran closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir pending The issue will be closed if no feedback is provided performance Performance or resource usage
    Projects
    Threading issues 🧵
    Status: Done
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gpshead @tiran @iritkatriel