Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor issues in reported Syntax errors #91368

Closed
MatthieuDartiailh mannequin opened this issue Apr 4, 2022 · 3 comments
Closed

Minor issues in reported Syntax errors #91368

MatthieuDartiailh mannequin opened this issue Apr 4, 2022 · 3 comments
Labels
3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@MatthieuDartiailh
Copy link
Mannequin

MatthieuDartiailh mannequin commented Apr 4, 2022

BPO 47212
Nosy @MatthieuDartiailh, @lysnikolaou, @pablogsal, @miss-islington
PRs
  • bpo-47212: Improve error messages for un-parenthesized generator expressions #32302
  • [3.10] Backport bpo-47212 (GH-32302) to Python 3.10 #32334
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-04-05.16:29:53.342>
created_at = <Date 2022-04-04.11:01:55.790>
labels = ['interpreter-core', 'type-bug', '3.10', '3.11']
title = 'Minor issues in reported Syntax errors'
updated_at = <Date 2022-04-05.16:29:53.342>
user = 'https://github.com/MatthieuDartiailh'

    bugs.python.org fields:

    activity = <Date 2022-04-05.16:29:53.342>
actor = 'AlexWaygood'
assignee = 'none'
closed = True
closed_date = <Date 2022-04-05.16:29:53.342>
closer = 'AlexWaygood'
components = ['Parser']
creation = <Date 2022-04-04.11:01:55.790>
creator = 'mdartiailh'
dependencies = []
files = []
hgrepos = []
issue_num = 47212
keywords = ['patch']
message_count = 3.0
messages = ['416662', '416777', '416787']
nosy_count = 4.0
nosy_names = ['mdartiailh', 'lys.nikolaou', 'pablogsal', 'miss-islington']
pr_nums = ['32302', '32334']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue47212'
versions = ['Python 3.10', 'Python 3.11']
    @MatthieuDartiailh
    Copy link
    Mannequin Author

    MatthieuDartiailh mannequin commented Apr 4, 2022

    Hi,
    While working on Pegen I noticed that:

    • the invalid_arguments rule would non point to the full generator expression in its second and fifth alternatives
    • when reporting an indentation error after a bare except, the error is actually a SyntaxError

    I will open a PR shortly to address both since the changes are quite minimal IMO.

    @MatthieuDartiailh MatthieuDartiailh mannequin added 3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Apr 4, 2022
    @pablogsal
    Copy link
    Member

    New changeset aa0f056 by Matthieu Dartiailh in branch 'main':
    bpo-47212: Improve error messages for un-parenthesized generator expressions (GH-32302)
    aa0f056

    @miss-islington
    Copy link
    Contributor

    New changeset 94609e3 by Matthieu Dartiailh in branch '3.10':
    [3.10] Backport bpo-47212 (GH-32302) to Python 3.10 (GH-32334)
    94609e3

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @pablogsal @miss-islington @AlexWaygood