Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old ctypes.macholib tests are ignored by python -m test #91265

Closed
arhadthedev opened this issue Mar 24, 2022 · 1 comment · Fixed by #32094
Closed

Old ctypes.macholib tests are ignored by python -m test #91265

arhadthedev opened this issue Mar 24, 2022 · 1 comment · Fixed by #32094
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@arhadthedev
Copy link
Member

BPO 47109
Nosy @arhadthedev
PRs
  • gh-91265: Make old ctypes.macholib tests runned by python -m test #32094
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2022-03-24.10:44:34.631>
labels = ['type-bug', '3.8', '3.9', '3.10', '3.11', '3.7', 'tests']
title = 'Old ctypes.macholib tests are ignored by python -m test'
updated_at = <Date 2022-03-24.10:44:47.148>
user = 'https://github.com/arhadthedev'

    bugs.python.org fields:

    activity = <Date 2022-03-24.10:44:47.148>
actor = 'arhadthedev'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2022-03-24.10:44:34.631>
creator = 'arhadthedev'
dependencies = []
files = []
hgrepos = []
issue_num = 47109
keywords = ['patch']
message_count = 1.0
messages = ['415935']
nosy_count = 1.0
nosy_names = ['arhadthedev']
pr_nums = ['32094']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue47109'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']
    @arhadthedev
    Copy link
    Member Author

    Some tests for ctypes.macholib.dyld and all tests for ctypes.macholib.dylib and ctypes.macholib.framework are located outside of expected ctypes.test module and were not ported from assert to unittest facilities. This causes the following problems:

    • the tests aren't run by python -m test so they are effectively dead
    • an end user can run them by python -m ctypes.macholib.dyld, python -m ctypes.macholib.dylib, and python -m ctypes.macholib.framework
    • they are available even if a user chose to install CPython without tests

    @arhadthedev arhadthedev added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Mar 24, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @arhadthedev arhadthedev mentioned this issue Apr 10, 2022
    Merged
    ronaldoussoren pushed a commit that referenced this issue Apr 18, 2022
    @arhadthedev
    gh-91265: Make old ctypes.macholib tests runned by python -m test (g…
    804ea2d 
    …h-32094)

* Move tests from ctypes.macholib.dy* to ctypes.test
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    gh-91265: Make old ctypes.macholib tests runned by python -m test arhadthedev/cpython
    1 participant
    @arhadthedev