Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate modules listed in PEP 594 #91217

Closed
brettcannon opened this issue Mar 18, 2022 · 14 comments
Closed

Deprecate modules listed in PEP 594 #91217

brettcannon opened this issue Mar 18, 2022 · 14 comments
Assignees
@brettcannon
Labels
3.11 only security fixes deferred-blocker stdlib Python modules in the Lib dir

Comments

@brettcannon
Copy link
Member

BPO 47061
Nosy @warsaw, @brettcannon, @hugovk, @miss-islington, @tirkarthi
PRs
  • bpo-47061: document module deprecations due to PEP 594 #31984
  • [3.10] bpo-47061: document module deprecations due to PEP 594 (GH-31984) #32039
  • [3.9] bpo-47061: document module deprecations due to PEP 594 (GH-31984) #32082
  • bpo-47061: deprecate the aifc module #32134
  • bpo-47061: use warnings._deprecated() with asynchat, asyncore, and smtpd #32350
  • bpo-47061: deprecate audioop #32392
  • bpo-47061: deprecate cgi and cgitb #32410
    		•
    Dependencies
  • bpo-47022: PEP 594: Document removal of asynchat, asyncore and smtpd
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
closed_at = None
created_at = <Date 2022-03-18.19:46:10.638>
labels = ['deferred-blocker', 'library', '3.11']
title = 'Deprecate modules listed in PEP 594'
updated_at = <Date 2022-04-08.03:39:21.812>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2022-04-08.03:39:21.812>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2022-03-18.19:46:10.638>
creator = 'brett.cannon'
dependencies = ['47022']
files = []
hgrepos = []
issue_num = 47061
keywords = ['patch']
message_count = 8.0
messages = ['415521', '415525', '415725', '415732', '415733', '415906', '416804', '416896']
nosy_count = 5.0
nosy_names = ['barry', 'brett.cannon', 'hugovk', 'miss-islington', 'xtreak']
pr_nums = ['31984', '32039', '32082', '32134', '32350', '32392', '32410']
priority = 'deferred blocker'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue47061'
versions = ['Python 3.11']
    @brettcannon
    Copy link
    Member Author

    brettcannon commented Mar 18, 2022 •
    edited

    https://peps.python.org/pep-0594/

    The SC has asked that all modules deprecated by PEP-594 have the documented deprecation backported. The message should also not have any specific removal version to avoid any potential delay, but then making the bugfix-only docs incorrect.

    @brettcannon brettcannon added the 3.11 only security fixes label Mar 18, 2022
    @brettcannon brettcannon self-assigned this Mar 18, 2022
    @brettcannon brettcannon added the stdlib Python modules in the Lib dir label Mar 18, 2022
    @brettcannon brettcannon changed the title Document PEP 594 deprecations Deprecate modules listed in PEP 594 Mar 18, 2022
    @brettcannon
    Copy link
    Member Author

    The first PR for documenting the modules is up. Once this gets merged and backported I will add a helper function in warnings and then make the appropriate code changes.

    @miss-islington
    Copy link
    Contributor

    New changeset 9ac2de9 by Brett Cannon in branch 'main':
    bpo-47061: document module deprecations due to PEP-594 (GH-31984)
    9ac2de9

    @miss-islington
    Copy link
    Contributor

    New changeset c353835 by Miss Islington (bot) in branch '3.10':
    [3.10] bpo-47061: document module deprecations due to PEP-594 (GH-31984) (GH-32039)
    c353835

    @brettcannon
    Copy link
    Member Author

    One thing I forgot to mention is that I will be updating What's New as the code deprecations land.

    @miss-islington
    Copy link
    Contributor

    New changeset e513b81 by Hugo van Kemenade in branch '3.9':
    [3.9] bpo-47061: document module deprecations due to PEP-594 (GH-31984) (GH-32082)
    e513b81

    @brettcannon
    Copy link
    Member Author

    New changeset c1d93b6 by Brett Cannon in branch 'main':
    bpo-47061: deprecate the aifc module (GH-32134)
    c1d93b6

    @brettcannon
    Copy link
    Member Author

    New changeset 32b3387 by Brett Cannon in branch 'main':
    bpo-47061: use warnings._deprecated() with asynchat, asyncore, and smtpd (GH-32350)
    32b3387

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    This was referenced Apr 11, 2022
    Closed
    Closed
    Closed
    Merged
    Closed
    Closed
    Open
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Merged
    Closed
    brettcannon added a commit that referenced this issue Apr 14, 2022
    @brettcannon
    gh-91217: deprecate msilib (GH-91515)
    1b6cd87
    brettcannon added a commit that referenced this issue Apr 15, 2022
    @brettcannon
    gh-91217: deprecate nntplib (GH-91543)
    c9e231d
    miss-islington pushed a commit that referenced this issue Apr 16, 2022
    @brettcannon
    gh-91217: deprecate nis (GH-91606)
    9f06ff9 
    Automerge-Triggered-By: GH:brettcannon
    miss-islington pushed a commit that referenced this issue Apr 17, 2022
    @brettcannon
    gh-91217: deprecate ossaudiodev (GH-91641)
    ceea071 
    Automerge-Triggered-By: GH:brettcannon
    brettcannon added a commit that referenced this issue Apr 22, 2022
    @brettcannon
    gh-91217: deprecate-pipes (GH-91779)
    2551a6c
    brettcannon added a commit that referenced this issue Apr 22, 2022
    @brettcannon @hugovk
    gh-91217: deprecate-sndhdr (#91806)
    e7929cb 
    Also inline necessary functionality from `sndhdr` into `email.mime.audio` for `MIMEAudio`.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    brettcannon added a commit that referenced this issue Apr 23, 2022
    @brettcannon @hugovk
    gh-91217: deprecate spwd (#91846)
    692e907 
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    brettcannon added a commit that referenced this issue Apr 25, 2022
    @brettcannon
    gh-91217: deprecate sunau (GH-91866)
    d174ebe
    This was referenced Apr 26, 2022
    Closed
    Closed
    Closed
    This was referenced Apr 26, 2022
    Closed
    Closed
    Closed
    Closed
    @vstinner
    Copy link
    Member

    I created the PR #91951 to deprecate the mailcap module (see issue #68966).

    brettcannon added a commit that referenced this issue Apr 26, 2022
    @brettcannon
    gh-91217: deprecate telnetlib (GH-91958)
    1af871e
    miss-islington pushed a commit that referenced this issue Apr 28, 2022
    @brettcannon
    gh-91217: deprecate uu (GH-92009)
    407c3af 
    Automerge-Triggered-By: GH:brettcannon
    miss-islington pushed a commit that referenced this issue Apr 30, 2022
    @brettcannon
    gh-91217: deprecate xdrlib (GH-92066)
    c2b5797 
    Automerge-Triggered-By: GH:brettcannon
    This was referenced May 28, 2022
    Closed
    Closed
    @wimglenn wimglenn mentioned this issue Oct 25, 2022
    Merged
    @bmw bmw mentioned this issue Nov 1, 2022
    Closed
    @gnat
    Copy link

    gnat commented Apr 19, 2023

    Is deprecating CGI a logical thing to do here? Was there any real benefit to this?

    There's very likely going to be breakage from this in the Python ecosystem. Deprecating CGI is kind of like deprecating HTTP or JSON or CSV.. it's a very well established standard.

    Just because "my current project at work" doesn't use something, doesn't mean it should go into the trashbin for everybody. Seems totally random.

    @hugovk
    Copy link
    Member

    hugovk commented Apr 19, 2023

    cgi has been moved to a separate package on PyPI that you can use instead:

    @brettcannon
    Copy link
    Member Author

    Is deprecating CGI a logical thing to do here? Was there any real benefit to this?

    Yes, please read the PEP for the motivation.

    @hugovk hugovk mentioned this issue May 9, 2023
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @brettcannon brettcannon

    Labels
    3.11 only security fixes deferred-blocker stdlib Python modules in the Lib dir
    Projects
    Release and Deferred blockers 🚫
    Archived in project
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @gnat @brettcannon @vstinner @hugovk @miss-islington