Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not detect launcher installer build failure #91188

Closed
zooba opened this issue Mar 16, 2022 · 4 comments
Closed

CI does not detect launcher installer build failure #91188

zooba opened this issue Mar 16, 2022 · 4 comments
Assignees
@zooba
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes

Comments

@zooba
Copy link
Member

zooba commented Mar 16, 2022

BPO 47032
Nosy @zooba, @miss-islington
PRs
  • bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails #31921
  • [3.10] bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921) #31926
  • [3.9] bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921) #31927
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2022-03-16.12:23:37.964>
created_at = <Date 2022-03-16.00:20:54.847>
labels = ['3.9', '3.10', '3.11']
title = 'CI does not detect launcher installer build failure'
updated_at = <Date 2022-03-16.12:23:37.963>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2022-03-16.12:23:37.963>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2022-03-16.12:23:37.964>
closer = 'steve.dower'
components = []
creation = <Date 2022-03-16.00:20:54.847>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 47032
keywords = ['patch']
message_count = 4.0
messages = ['415308', '415315', '415318', '415319']
nosy_count = 2.0
nosy_names = ['steve.dower', 'miss-islington']
pr_nums = ['31921', '31926', '31927']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue47032'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @zooba
    Copy link
    Member Author

    zooba commented Mar 16, 2022

    When changes are made under the Tools/msi directory, extra tests are run in GitHub Actions to build the installer.

    Apparently, these tests do not fail when the launcher installer fails to build. They need to.

    @zooba zooba added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Mar 16, 2022
    @zooba zooba self-assigned this Mar 16, 2022
    @zooba zooba added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Mar 16, 2022
    @zooba zooba self-assigned this Mar 16, 2022
    @zooba
    Copy link
    Member Author

    zooba commented Mar 16, 2022

    New changeset 7c77652 by Steve Dower in branch 'main':
    bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921)
    7c77652

    @miss-islington
    Copy link
    Contributor

    New changeset 04fdbb4 by Steve Dower in branch '3.10':
    [3.10] bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921) (GH-31926)
    04fdbb4

    @miss-islington
    Copy link
    Contributor

    New changeset ad6ddd8 by Steve Dower in branch '3.9':
    [3.9] bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921) (GH-31927)
    ad6ddd8

    @zooba zooba closed this as completed Mar 16, 2022
    @zooba zooba closed this as completed Mar 16, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington