Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FASTCALL calling convention in generator.throw #91100

Closed
kumaraditya303 opened this issue Mar 7, 2022 · 2 comments
Closed

Use FASTCALL calling convention in generator.throw #91100

kumaraditya303 opened this issue Mar 7, 2022 · 2 comments
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@kumaraditya303
Copy link
Contributor

BPO 46944
Nosy @markshannon, @kumaraditya303
PRs
  • bpo-46944: use FASTCALL calling convention in generator.throw #31723
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-03-12.10:26:58.903>
    created_at = <Date 2022-03-07.11:56:36.986>
    labels = ['interpreter-core', '3.11', 'performance']
    title = 'Use FASTCALL calling convention in generator.throw'
    updated_at = <Date 2022-03-12.10:26:58.903>
    user = 'https://github.com/kumaraditya303'

    bugs.python.org fields:

    activity = <Date 2022-03-12.10:26:58.903>
    actor = 'kumaraditya'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-03-12.10:26:58.903>
    closer = 'kumaraditya'
    components = ['Interpreter Core']
    creation = <Date 2022-03-07.11:56:36.986>
    creator = 'kumaraditya'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46944
    keywords = []
    message_count = 2.0
    messages = ['414660', '414908']
    nosy_count = 2.0
    nosy_names = ['Mark.Shannon', 'kumaraditya']
    pr_nums = ['31723']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue46944'
    versions = ['Python 3.11']

    @kumaraditya303
    Copy link
    Contributor Author

    Use FASTCALL calling convention in generator.throw to avoid creating a temporary tuple to pass arguments to the function.

    @kumaraditya303 kumaraditya303 added 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 7, 2022
    @markshannon
    Copy link
    Member

    New changeset 304197b by Kumar Aditya in branch 'main':
    bpo-46944: use FASTCALL calling convention in generator.throw (GH-31723)
    304197b

    @kumaraditya303 kumaraditya303 added the performance Performance or resource usage label Mar 12, 2022
    @kumaraditya303 kumaraditya303 added the performance Performance or resource usage label Mar 12, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants