Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows and MacOS installer to SQLite 3.38.4 #91063

Closed
felixxm mannequin opened this issue Mar 3, 2022 · 27 comments · Fixed by #92322, #92580, #32148, #31655 or #31656
Closed

Update Windows and MacOS installer to SQLite 3.38.4 #91063

felixxm mannequin opened this issue Mar 3, 2022 · 27 comments · Fixed by #92322, #92580, #32148, #31655 or #31656
Labels
3.11 bug and security fixes OS-mac OS-windows type-feature A feature request or enhancement

Comments

@felixxm
Copy link
Mannequin

felixxm mannequin commented Mar 3, 2022

BPO 46907
Nosy @pfmoore, @ronaldoussoren, @tjguk, @ned-deily, @zware, @zooba, @tirkarthi, @erlend-aasland, @felixxm, @180909
PRs
  • bpo-46907: Update Windows installer to SQLite 3.38.1. #31655
  • bpo-46907: Update macOS installer to SQLite 3.38.1. #31656
  • bpo-46907: Update Windows installer to SQLite 3.38.2. #32147
  • gh-91063: Update macOS installer to SQLite 3.38.4. #32148
  • bpo-46907: Update windows sqlite version to 3.38.2 #32149
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2022-03-03.08:27:32.906>
    labels = ['OS-mac', 'type-feature', 'OS-windows', '3.11']
    title = 'Update Windows and MacOS installer to SQLite 3.38.2'
    updated_at = <Date 2022-03-31.18:05:03.473>
    user = 'https://github.com/felixxm'

    bugs.python.org fields:

    activity = <Date 2022-03-31.18:05:03.473>
    actor = 'erlendaasland'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['macOS', 'Windows']
    creation = <Date 2022-03-03.08:27:32.906>
    creator = 'felixxm'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46907
    keywords = ['patch']
    message_count = 17.0
    messages = ['414412', '414413', '414414', '415015', '415251', '415265', '415266', '415269', '415270', '415271', '416140', '416274', '416429', '416442', '416446', '416450', '416453']
    nosy_count = 10.0
    nosy_names = ['paul.moore', 'ronaldoussoren', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'xtreak', 'erlendaasland', 'felixxm', 'wangjiahua']
    pr_nums = ['31655', '31656', '32147', '32148', '32149']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue46907'
    versions = ['Python 3.11']

    @felixxm
    Copy link
    Mannequin Author

    felixxm mannequin commented Mar 3, 2022

    SQLite 3.37.0 was released on 2022-02-22: https://sqlite.org/releaselog/3_38_0.html

    @felixxm felixxm mannequin added 3.11 bug and security fixes OS-mac OS-windows type-feature A feature request or enhancement labels Mar 3, 2022
    @erlend-aasland
    Copy link
    Contributor

    +1 for SQLite 3.38.0.

    @erlend-aasland
    Copy link
    Contributor

    Steve, would you mind updating the cpython sources repo? (No hurry; let's see if a patch release surfaces first.)

    @ned-deily
    Copy link
    Member

    @ned-deily ned-deily changed the title Update Windows and MacOS installer to SQLite 3.38.0. Update Windows and MacOS installer to SQLite 3.38.1 Mar 12, 2022
    @ned-deily ned-deily changed the title Update Windows and MacOS installer to SQLite 3.38.0. Update Windows and MacOS installer to SQLite 3.38.1 Mar 12, 2022
    @ned-deily
    Copy link
    Member

    New changeset ea786a8 by Mariusz Felisiak in branch 'main':
    bpo-46907: Update macOS installer to SQLite 3.38.1. (GH-31656)
    ea786a8

    @zooba
    Copy link
    Member

    zooba commented Mar 15, 2022

    New changeset a8c728b by Mariusz Felisiak in branch 'main':
    bpo-46907: Update Windows installer to SQLite 3.38.1. (GH-31655)
    a8c728b

    @zooba
    Copy link
    Member

    zooba commented Mar 15, 2022

    Was there any reason/need to backport this?

    @ned-deily
    Copy link
    Member

    I think we can hold off on deciding whether to backport until at least the next round of bugfix releases. I don't know of any pressing reason one way or the other, ATM.

    @erlend-aasland
    Copy link
    Contributor

    Updating to SQLite 3.37 was backported because of a data corruption bug that was fixed. AFAIK, there’s nothing like that in 3.38. I would prefer waiting to see if more patch releases appear. (That was also my intent, given how many patch releases we saw with 3.35; I’ll start using the dont-merge label from now on.)

    @erlend-aasland
    Copy link
    Contributor

    Closing this tonight, unless someone objects.

    @ned-deily
    Copy link
    Member

    3.38.2 was released on 2022-03-26. Since the update to 3.38.1 hasn't yet been in a 3.11.0 alpha release, I'm re-open this issue.

    https://sqlite.org/releaselog/3_38_2.html

    @ned-deily ned-deily reopened this Mar 28, 2022
    @ned-deily ned-deily changed the title Update Windows and MacOS installer to SQLite 3.38.1 Update Windows and MacOS installer to SQLite 3.38.2 Mar 28, 2022
    @ned-deily ned-deily reopened this Mar 28, 2022
    @ned-deily ned-deily changed the title Update Windows and MacOS installer to SQLite 3.38.1 Update Windows and MacOS installer to SQLite 3.38.2 Mar 28, 2022
    @erlend-aasland
    Copy link
    Contributor

    Let's hold these PRs a couple of weeks in case more patch releases appear. IMO we can hold it until a week or two before the beta phase kicks in.

    @felixxm
    Copy link
    Mannequin Author

    felixxm mannequin commented Mar 31, 2022

    https://sqlite.org/src/info/336851b191fe79f0 was merged to the 3.38 branch, so we should expect 3.38.3 in the coming days.

    @zooba
    Copy link
    Member

    zooba commented Mar 31, 2022

    Erlend - would you be up for write permissions on the cpython-source-deps repo so you can push the SQLite updates yourself.

    As I've mentioned before, merging PRs into that repo isn't any easier than doing it directly (since you also need to check file hashes and add a tag), but doing it yourself is easier than waiting on me or Zach.

    @erlend-aasland
    Copy link
    Contributor

    Erlend - would you be up for write permissions on the cpython-source-deps repo so you can push the SQLite updates yourself.

    Yep, I’m fine with that.

    @zooba
    Copy link
    Member

    zooba commented Mar 31, 2022

    Done. Feel free to push directly to the repo, and bear in mind that changes may be reflected in any version build at any point, which is why we use tags (ahem... mostly... we've gotten it wrong before). Fourth field of the version number is our private one, so it gets incremented if we need to patch or re-release something, rather than changing the tag, unless we really do want to force change the tag.

    Feel free to reach out if you have any questions. Otherwise, SQLite updates are all yours :)

    @erlend-aasland
    Copy link
    Contributor

    Great, thanks :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland
    Copy link
    Contributor

    erlend-aasland commented Apr 24, 2022

    https://sqlite.org/src/info/336851b191fe79f0 was merged to the 3.38 branch, so we should expect 3.38.3 in the coming days.

    I haven't seen any signs for an upcoming release on the forum, and the 3.38 branch haven't been touched in weeks. Let's just merge gh-32147 and gh-32148 now, so we have a fresh lib for the upcoming alpha beta! :)

    @zooba
    Copy link
    Member

    zooba commented Apr 25, 2022

    Are we backporting this? Normally it needs manual backports, but I can try the tags if someone lets me know how far back it ought to go.

    @felixxm
    Copy link
    Contributor

    felixxm commented Apr 26, 2022

    I can prepare backports, if needed.

    @erlend-aasland
    Copy link
    Contributor

    Last time we backported an SQLite bump, it was because of a data corruption bugfix. AFAIK, there's nothing like that in SQLite 3.38, but historically there has been no consistency for how to backport these PRs. I'm fine with backporting if the release managers are :)

    erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Apr 26, 2022
    From the SQLite 3.38 changelog:
    
      The JSON functions are now built-ins. It is no longer necessary to use
      the -DSQLITE_ENABLE_JSON1 compile-time option to enable JSON support.
    @erlend-aasland
    Copy link
    Contributor

    erlend-aasland commented Apr 27, 2022

    I haven't seen any signs for an upcoming release on the forum, and the 3.38 branch haven't been touched in weeks. Let's just merge gh-32147 and gh-32148 now, so we have a fresh lib for the upcoming alpha beta! :)

    Hah, I'll eat those words! 😆 The SQLite 3.38.3 release announcement just arrived in my inbox.

    @felixxm, if you prepare new PR's, can you also remove the now obsolete SQLITE_OMIT_JSON compile from the Mac and Windows builds?

    @felixxm
    Copy link
    Contributor

    felixxm commented Apr 27, 2022

    @erlend-aasland Will do, thanks 👍

    @erlend-aasland
    Copy link
    Contributor

    FYI, I've updated the sources deps repo, so all is set for the Windows installer/PR.

    @ned-deily
    Copy link
    Member

    And today 3.38.4 was released. Sigh!

    @erlend-aasland
    Copy link
    Contributor

    erlend-aasland commented May 6, 2022

    Quoting an email that appeared in my inbox, some forty minutes ago:

    SQLite version 3.38.5 is now available on the website.

    As previously announced, the 3.38.4 patch release contained a bug. There was a last-minute change, and rather than run the full test suite after that change, only spot-checks were run. Those spot checks missed a fatal flaw in the last-minute change. This patch release fixes that problem that was introduced by the last-minute change in the previous release.

    The lesson from this is: Always, always, always run the full test suite before every release, even for just a "trivial" change. I knew this. But sometimes I need reminders.

    Sorry for the extra, unnecessary, release...

    The good news is that the new release apparently only affects the CLI, so we're good to go. Quoting the 3.38.5 changelog:

    Fix a blunder in the CLI of the 3.38.4 release.

    Further information, quoting their news page:

    This blunder did not affect the core SQLite library. It only affected the CLI.

    @erlend-aasland
    Copy link
    Contributor

    I'm closing this issue, as the macOS and Windows installers are now updated to SQLite 3.38.4. If a relevant SQLite 3.38 patch release appears in the future, open a new issue.

    Thanks for the PRs, Mariusz!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment