Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE combined opcode #90979

Closed
sweeneyde opened this issue Feb 22, 2022 · 4 comments
Closed

Add LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE combined opcode #90979

sweeneyde opened this issue Feb 22, 2022 · 4 comments

Comments

@sweeneyde
Copy link
Member

BPO 46823
Nosy @markshannon, @brandtbucher, @sweeneyde
PRs
  • bpo-46823: Implement LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE #31484
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2022-02-22.05:11:54.712>
labels = []
title = 'Add LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE combined opcode'
updated_at = <Date 2022-03-03.20:07:12.224>
user = 'https://github.com/sweeneyde'

    bugs.python.org fields:

    activity = <Date 2022-03-03.20:07:12.224>
actor = 'brandtbucher'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2022-02-22.05:11:54.712>
creator = 'Dennis Sweeney'
dependencies = []
files = []
hgrepos = []
issue_num = 46823
keywords = ['patch']
message_count = 3.0
messages = ['413692', '413916', '414463']
nosy_count = 3.0
nosy_names = ['Mark.Shannon', 'brandtbucher', 'Dennis Sweeney']
pr_nums = ['31484']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue46823'
versions = []
    @sweeneyde
    Copy link
    Member Author

    See faster-cpython/ideas#291

    @markshannon
    Copy link
    Member

    New changeset a52d252 by Dennis Sweeney in branch 'main':
    bpo-46823: Implement LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE superinstruction (GH-31484)
    a52d252

    @akulakov akulakov changed the title Add LOAD_FAST__LOAD_ATTR_INSTACE_VALUE combined opcode Add LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE combined opcode Mar 2, 2022
    @brandtbucher
    Copy link
    Member

    Reopening since this needed to be removed for #31640.

    @brandtbucher brandtbucher reopened this Mar 3, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @markshannon
    Copy link
    Member

    The adapter interpreter is strictly a one-instruction-at-a-time optimizer, and does not specialize superinstructions.
    LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE is clearly a specialized superinstruction, so we should leave it for tier-2.
    Any tier-2 interpreter will have its own set of superinstructions, presumably automatically generated.

    @markshannon markshannon reopened this Aug 15, 2022
    @markshannon markshannon closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @markshannon @sweeneyde @brandtbucher