Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated symbols when linking embedded Python with libexpat #90940

Closed
yilei mannequin opened this issue Feb 17, 2022 · 8 comments
Closed

Duplicated symbols when linking embedded Python with libexpat #90940

yilei mannequin opened this issue Feb 17, 2022 · 8 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build topic-XML

Comments

@yilei
Copy link
Mannequin

yilei mannequin commented Feb 17, 2022

BPO 46784
Nosy @gpshead, @ned-deily, @ambv, @corona10, @yilei, @miss-islington
PRs
  • bpo-46784: Add newly exported expat symbols to the namespace. #31397
  • [3.10] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) #31416
  • [3.9] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) #31417
  • [3.7] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) #31418
  • [3.8] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) #31419
  • [3.10] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) #31420
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-02-19.01:26:06.434>
created_at = <Date 2022-02-17.23:35:45.944>
labels = ['3.7', '3.8', '3.9', '3.10', '3.11', 'expert-XML', 'build']
title = 'Duplicated symbols when linking embedded Python with libexpat'
updated_at = <Date 2022-03-08.09:35:51.740>
user = 'https://github.com/yilei'

    bugs.python.org fields:

    activity = <Date 2022-03-08.09:35:51.740>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2022-02-19.01:26:06.434>
closer = 'gregory.p.smith'
components = ['Build', 'XML']
creation = <Date 2022-02-17.23:35:45.944>
creator = 'yilei'
dependencies = []
files = []
hgrepos = []
issue_num = 46784
keywords = ['patch']
message_count = 8.0
messages = ['413464', '413515', '413516', '413520', '413521', '413522', '413670', '414738']
nosy_count = 6.0
nosy_names = ['gregory.p.smith', 'ned.deily', 'lukasz.langa', 'corona10', 'yilei', 'miss-islington']
pr_nums = ['31397', '31416', '31417', '31418', '31419', '31420']
priority = 'normal'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue46784'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']
    @yilei
    Copy link
    Mannequin Author

    yilei mannequin commented Feb 17, 2022

    The libexpat 2.4.1 upgrade from https://bugs.python.org/issue44394 introduced the following new exported symbols:

    testingAccountingGetCountBytesDirect
    testingAccountingGetCountBytesIndirect
    unsignedCharToPrintable
    XML_SetBillionLaughsAttackProtectionActivationThreshold
    XML_SetBillionLaughsAttackProtectionMaximumAmplification

    We need to adjust Modules/expat/pyexpatns.h

    (The newer libexpat upgrade https://bugs.python.org/issue46400 has no new symbols).

    I'll send a PR.

    @yilei yilei mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes topic-XML labels Feb 17, 2022
    @miss-islington
    Copy link
    Contributor

    New changeset 6312c10 by Yilei "Dolee" Yang in branch 'main':
    bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397)
    6312c10

    @miss-islington
    Copy link
    Contributor

    New changeset 9aca412 by Miss Islington (bot) in branch '3.9':
    bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397)
    9aca412

    @gpshead
    Copy link
    Member

    gpshead commented Feb 19, 2022

    New changeset e05e3d2 by Gregory P. Smith in branch '3.10':
    [3.10] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) (GH-31420)
    e05e3d2

    @gpshead
    Copy link
    Member

    gpshead commented Feb 19, 2022

    PRs for 3.7 and 3.8 remain up to release blockers.

    @gpshead gpshead added the build The build process and cross-build label Feb 19, 2022
    @gpshead gpshead closed this as completed Feb 19, 2022
    @gpshead gpshead added the build The build process and cross-build label Feb 19, 2022
    @gpshead gpshead closed this as completed Feb 19, 2022
    @gpshead
    Copy link
    Member

    gpshead commented Feb 19, 2022

    err "release managers" same thing right? ;)

    @ned-deily
    Copy link
    Member

    New changeset 61f3c30 by Miss Islington (bot) in branch '3.7':
    bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) (GH-31418)
    61f3c30

    @ambv
    Copy link
    Contributor

    ambv commented Mar 8, 2022

    New changeset ccbc31e by Miss Islington (bot) in branch '3.8':
    bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) (GH-31419)
    ccbc31e

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build topic-XML
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @ambv @gpshead @ned-deily @miss-islington