Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys.excepthook documentation doesn't mention that it isn't called for SystemExit #90915

Closed
cjwatson mannequin opened this issue Feb 15, 2022 · 3 comments
Closed

sys.excepthook documentation doesn't mention that it isn't called for SystemExit #90915

cjwatson mannequin opened this issue Feb 15, 2022 · 3 comments
Labels
3.11 only security fixes docs Documentation in the Doc dir

Comments

@cjwatson
Copy link
Mannequin

cjwatson mannequin commented Feb 15, 2022 •
edited by bedevere-bot

BPO 46759
Nosy @cjwatson, @iritkatriel
PRs
  • GH-90915: Document that SystemExit doesn't trigger sys.excepthook #31357
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2022-02-15.12:10:41.510>
labels = ['3.11', 'docs']
title = "sys.excepthook documentation doesn't mention that it isn't called for SystemExit"
updated_at = <Date 2022-03-20.09:50:38.228>
user = 'https://github.com/cjwatson'

    bugs.python.org fields:

    activity = <Date 2022-03-20.09:50:38.228>
actor = 'iritkatriel'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2022-02-15.12:10:41.510>
creator = 'cjwatson'
dependencies = []
files = []
hgrepos = []
issue_num = 46759
keywords = ['patch']
message_count = 2.0
messages = ['413285', '415598']
nosy_count = 3.0
nosy_names = ['cjwatson', 'docs@python', 'iritkatriel']
pr_nums = ['31357']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue46759'
versions = ['Python 3.11']

    Linked PRs
    @cjwatson
    Copy link
    Mannequin Author

    cjwatson mannequin commented Feb 15, 2022

    In https://bugs.debian.org/1005803, Matthew Vernon reports that the library documentation for sys.excepthook doesn't mention the detail that that sys.excepthook isn't called for uncaught SystemExit exceptions, although help(sys) does mention this.

    (He also mentions that help(sys.excepthook) doesn't mention this. I think this would make less sense, since that gets the docstring of a particular implementation of an excepthook - on a given system it might not be Python's built-in version, for instance. But adding information to the main library documentation seems reasonable.)

    @cjwatson cjwatson mannequin added the 3.11 only security fixes label Feb 15, 2022
    @cjwatson cjwatson mannequin assigned docspython Feb 15, 2022
    @cjwatson cjwatson mannequin added docs Documentation in the Doc dir 3.11 only security fixes labels Feb 15, 2022
    @cjwatson cjwatson mannequin assigned docspython Feb 15, 2022
    @cjwatson cjwatson mannequin added the docs Documentation in the Doc dir label Feb 15, 2022
    @iritkatriel
    Copy link
    Member

    See also bpo-25489.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @bedevere-bot bedevere-bot mentioned this issue Jan 5, 2023
    Merged
    hugovk added a commit that referenced this issue Sep 7, 2023
    @cjwatson @kumaraditya303 @hugovk
    GH-90915: Document that SystemExit doesn't trigger sys.excepthook (#3…
    1294fce 
    …1357)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 7, 2023
    @cjwatson @kumaraditya303
    @hugovk @miss-islington
    pythonGH-90915: Document that SystemExit doesn't trigger sys.exceptho…
    6a00fe6 
    …ok (pythonGH-31357)

(cherry picked from commit 1294fce)

Co-authored-by: Colin Watson <cjwatson@debian.org>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    @bedevere-bot bedevere-bot mentioned this issue Sep 7, 2023
    Merged
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 7, 2023
    @cjwatson @kumaraditya303
    @hugovk @miss-islington
    pythonGH-90915: Document that SystemExit doesn't trigger sys.exceptho…
    06f6921 
    …ok (pythonGH-31357)

(cherry picked from commit 1294fce)

Co-authored-by: Colin Watson <cjwatson@debian.org>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    @bedevere-bot bedevere-bot mentioned this issue Sep 7, 2023
    Merged
    @hugovk
    Copy link
    Member

    hugovk commented Sep 7, 2023

    Thanks, fixed via #31357 and backports to 3.11.

    @hugovk hugovk closed this as completed Sep 7, 2023
    hugovk added a commit that referenced this issue Sep 7, 2023
    @miss-islington @cjwatson
    @kumaraditya303 @hugovk
    [3.11] GH-90915: Document that SystemExit doesn't trigger sys.excepth…
    417a7b5 
    …ook (GH-31357) (#109083)

Co-authored-by: Colin Watson <cjwatson@debian.org>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    Yhg1s pushed a commit that referenced this issue Sep 8, 2023
    @miss-islington @cjwatson
    @kumaraditya303 @hugovk
    [3.12] GH-90915: Document that SystemExit doesn't trigger sys.excepth…
    26f42b3 
    …ook (GH-31357) (#109082)

GH-90915: Document that SystemExit doesn't trigger sys.excepthook (GH-31357)
(cherry picked from commit 1294fce)

Co-authored-by: Colin Watson <cjwatson@debian.org>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes docs Documentation in the Doc dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @iritkatriel @hugovk