Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent registry virtualization in Windows Store package #90796

Closed
zooba opened this issue Feb 4, 2022 · 6 comments
Closed

Inconsistent registry virtualization in Windows Store package #90796

zooba opened this issue Feb 4, 2022 · 6 comments
Assignees
@zooba
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Feb 4, 2022

BPO 46638
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington
PRs
  • bpo-46638: Makes registry virtualisation setting stable when building MSIX packages #31130
  • [3.10] bpo-46638: Makes registry virtualisation setting stable when building MSIX packages (GH-31130) #31199
  • [3.9] bpo-46638: Makes registry virtualisation setting stable when building MSIX packages (GH-31130) #31200
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2022-02-09.16:15:34.156>
created_at = <Date 2022-02-04.16:16:10.406>
labels = ['3.10', 'type-bug', '3.9', 'OS-windows', '3.11']
title = 'Inconsistent registry virtualization in Windows Store package'
updated_at = <Date 2022-02-09.16:15:34.155>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2022-02-09.16:15:34.155>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2022-02-09.16:15:34.156>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2022-02-04.16:16:10.406>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 46638
keywords = ['patch']
message_count = 6.0
messages = ['412513', '412517', '412522', '412770', '412773', '412775']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['31130', '31199', '31200']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46638'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @zooba
    Copy link
    Member Author

    zooba commented Feb 4, 2022

    The build of the Store package detects whether the build PC supports disabling registry virtualisation or not when deciding whether to add it to the manifest. Because our release builds just moved from the windows-2019 image to the windows-2022 image, this setting changed and now builds have virtualisation disabled.

    While this is probably desirable for some users, having it happen without warning is bad.

    I'll check whether we can leave it unconditionally enabled for 3.11 and still install on older Windows versions. If it won't install, we'll just have to leave it disabled.

    @zooba zooba added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Feb 4, 2022
    @zooba zooba self-assigned this Feb 4, 2022
    @zooba zooba added OS-windows 3.11 only security fixes labels Feb 4, 2022
    @zooba zooba self-assigned this Feb 4, 2022
    @zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows labels Feb 4, 2022
    @zooba
    Copy link
    Member Author

    zooba commented Feb 4, 2022

    Okay, so it doesn't install at all on 1803. However, that's out of support 1, so I guess it doesn't matter.

    In theory, 1809 should be the first one that supports it. I'll try that, but I think we're okay to leave this turned on for 3.11.

    The changes for 3.9-3.10 will be to disable the option unconditionally.

    @zooba zooba changed the title Inconsistent registry use in Windows Store package Inconsistent registry virtualization in Windows Store package Feb 4, 2022
    @zooba zooba changed the title Inconsistent registry use in Windows Store package Inconsistent registry virtualization in Windows Store package Feb 4, 2022
    @zooba
    Copy link
    Member Author

    zooba commented Feb 4, 2022

    Didn't work on 1809, but it does work on 20H2, which is the earliest update that will still be supported when 3.11 ships. I didn't try the ones in between, but I think we're okay to ignore them.

    Interestingly, double-clicking the MSIX on Windows 11 refuses to install because of the unvirtualised resources, but on earlier Windows it's fine. The Powershell command (Add-AppxPackage <filename>) does work fine though. I'll see if I can find out what happened.

    @zooba
    Copy link
    Member Author

    zooba commented Feb 7, 2022

    New changeset 3a5afc1 by Steve Dower in branch 'main':
    bpo-46638: Makes registry virtualisation setting stable when building MSIX packages (GH-31130)
    3a5afc1

    @miss-islington
    Copy link
    Contributor

    New changeset 9c45390 by Miss Islington (bot) in branch '3.10':
    bpo-46638: Makes registry virtualisation setting stable when building MSIX packages (GH-31130)
    9c45390

    @zooba
    Copy link
    Member Author

    zooba commented Feb 7, 2022

    New changeset 76b0727 by Miss Islington (bot) in branch '3.9':
    bpo-46638: Makes registry virtualisation setting stable when building MSIX packages (GH-31130)
    76b0727

    @zooba zooba closed this as completed Feb 9, 2022
    @zooba zooba closed this as completed Feb 9, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @busylog busylog mentioned this issue Aug 6, 2022
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington