Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement vectorcall protocol for weakref_call() #90639

Closed
corona10 opened this issue Jan 23, 2022 · 2 comments
Closed

Implement vectorcall protocol for weakref_call() #90639

corona10 opened this issue Jan 23, 2022 · 2 comments
Assignees
@corona10
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@corona10
Copy link
Member

BPO 46481
Nosy @vstinner, @corona10
PRs
  • bpo-46481: Implement vectorcall for weakref.ref.__call__ method. #30820
    		•
    Files
  • bench_weakref.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/corona10'
closed_at = <Date 2022-01-23.15:40:10.539>
created_at = <Date 2022-01-23.06:50:14.971>
labels = ['interpreter-core', '3.11', 'performance']
title = 'Implement vectorcall protocol for weakref_call()'
updated_at = <Date 2022-01-23.15:40:10.538>
user = 'https://github.com/corona10'

    bugs.python.org fields:

    activity = <Date 2022-01-23.15:40:10.538>
actor = 'corona10'
assignee = 'corona10'
closed = True
closed_date = <Date 2022-01-23.15:40:10.539>
closer = 'corona10'
components = ['Interpreter Core']
creation = <Date 2022-01-23.06:50:14.971>
creator = 'corona10'
dependencies = []
files = ['50578']
hgrepos = []
issue_num = 46481
keywords = ['patch']
message_count = 2.0
messages = ['411350', '411379']
nosy_count = 2.0
nosy_names = ['vstinner', 'corona10']
pr_nums = ['30820']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue46481'
versions = ['Python 3.11']
    @corona10
    Copy link
    Member Author

    Triggered by Victor's suggestion:

    • Well-used.
    • Easy to enhance performance.
    • Performance enhancement is notable.
      Mean +- std dev: [weakref_base] 49.3 ns +- 2.2 ns -> [weakref_vectorcall] 27.7 ns +- 0.9 ns: 1.78x faster

    @corona10 corona10 added the 3.11 only security fixes label Jan 23, 2022
    @corona10 corona10 self-assigned this Jan 23, 2022
    @corona10 corona10 added interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.11 only security fixes labels Jan 23, 2022
    @corona10 corona10 self-assigned this Jan 23, 2022
    @corona10 corona10 added performance Performance or resource usage interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jan 23, 2022
    @corona10
    Copy link
    Member Author

    New changeset 76dc047 by Dong-hee Na in branch 'main':
    bpo-46481: Implement vectorcall for weakref.ref.__call__ method. (GH-30820)
    76dc047

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @corona10 corona10

    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @corona10