Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use global singletons for single byte bytes objects in deepfreeze #90629

Closed
kumaraditya303 opened this issue Jan 22, 2022 · 3 comments
Closed

use global singletons for single byte bytes objects in deepfreeze #90629

kumaraditya303 opened this issue Jan 22, 2022 · 3 comments
Labels
3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@kumaraditya303
Copy link
Contributor

BPO 46471
Nosy @gvanrossum, @erlend-aasland, @kumaraditya303
PRs
  • bpo-46471: use global singletons for single byte bytes objects #30781
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-23.21:33:18.476>
created_at = <Date 2022-01-22.11:04:42.642>
labels = ['type-feature', 'build', '3.11']
title = 'use global singletons for single byte bytes objects in deepfreeze'
updated_at = <Date 2022-01-23.21:33:18.476>
user = 'https://github.com/kumaraditya303'

    bugs.python.org fields:

    activity = <Date 2022-01-23.21:33:18.476>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-23.21:33:18.476>
closer = 'gvanrossum'
components = ['Build']
creation = <Date 2022-01-22.11:04:42.642>
creator = 'kumaraditya'
dependencies = []
files = []
hgrepos = []
issue_num = 46471
keywords = ['patch']
message_count = 3.0
messages = ['411245', '411390', '411398']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'erlendaasland', 'kumaraditya']
pr_nums = ['30781']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46471'
versions = ['Python 3.11']
    @kumaraditya303
    Copy link
    Contributor Author

    By using global singletons for single byte bytes objects in deepfreeze, there is no need to generate c code for it so it reduces the size of generated c file and reduces memory use of the objects when they are allocated on the heap as now they are statically allocated and they are already immortal.

    @kumaraditya303 kumaraditya303 added 3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement labels Jan 22, 2022
    @gvanrossum
    Copy link
    Member

    New changeset ca78130 by Kumar Aditya in branch 'main':
    bpo-46471: Use single byte singletons (GH-30781)
    ca78130

    @erlend-aasland
    Copy link
    Contributor

    Can we close this, or are you expecting more changes?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gvanrossum @erlend-aasland @kumaraditya303