Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning compiling main on Windows #90563

Closed
terryjreedy opened this issue Jan 16, 2022 · 3 comments
Closed

Warning compiling main on Windows #90563

terryjreedy opened this issue Jan 16, 2022 · 3 comments
Labels
3.11 only security fixes build The build process and cross-build OS-windows

Comments

@terryjreedy
Copy link
Member

BPO 46405
Nosy @terryjreedy, @pfmoore, @tjguk, @markshannon, @zware, @zooba, @kumaraditya303
PRs
  • bpo-46405: fix msvc compiler warnings #30627
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-17.18:07:26.123>
created_at = <Date 2022-01-16.23:34:44.968>
labels = ['build', 'OS-windows', '3.11']
title = 'Warning compiling main on Windows'
updated_at = <Date 2022-01-17.18:07:26.122>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2022-01-17.18:07:26.122>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-17.18:07:26.123>
closer = 'terry.reedy'
components = ['Build', 'Windows']
creation = <Date 2022-01-16.23:34:44.968>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 46405
keywords = ['patch']
message_count = 3.0
messages = ['410734', '410804', '410814']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'paul.moore', 'tim.golden', 'Mark.Shannon', 'zach.ware', 'steve.dower', 'kumaraditya']
pr_nums = ['30627']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue46405'
versions = ['Python 3.11']
    @terryjreedy
    Copy link
    Member Author

    Sometime between Jan 7 and Jan 16 (today) this VC compile warning appeared (debug build).
    "specialize.c
    ..\Python\specialize.c(1243): warning C4018: '<': signed/unsigned mismatch [f:\dev\3x\PCbuild\_freeze_module.vcxproj]"
    Same is repeated at end of compile.

    Could and should such warnings be treated as errors in CI Windows' build? Or is it specific to debug build?

    @terryjreedy terryjreedy added 3.11 only security fixes build The build process and cross-build OS-windows labels Jan 16, 2022
    @markshannon
    Copy link
    Member

    New changeset a4bc221 by Kumar Aditya in branch 'main':
    bpo-46405: fix msvc compiler warnings (GH-30627)
    a4bc221

    @terryjreedy
    Copy link
    Member Author

    Thank you Kumar for the quick fix. Just got a clean compile.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @markshannon @terryjreedy