Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractEventLoop.call_* should reflect the 'context' argument #90436

Closed
asvetlov opened this issue Jan 6, 2022 · 5 comments
Closed

AbstractEventLoop.call_* should reflect the 'context' argument #90436

asvetlov opened this issue Jan 6, 2022 · 5 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@asvetlov
Copy link
Contributor

asvetlov commented Jan 6, 2022

BPO 46278
Nosy @asvetlov, @1st1, @miss-islington, @kumaraditya303
PRs
  • bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods #30427
  • bpo-46278: fix typo introduced in GH-30427 #30430
  • [3.10] bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods (GH-30427) #30428
  • [3.9] bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods (GH-30427) #30429
  • [3.10] bpo-46278: fix typo introduced in GH-30427 (GH-30430) #30431
  • [3.9] bpo-46278: fix typo introduced in GH-30427 (GH-30430) #30432
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-06.14:44:55.790>
created_at = <Date 2022-01-06.11:36:02.498>
labels = ['3.11', 'type-bug', '3.9', '3.10', 'expert-asyncio']
title = "AbstractEventLoop.call_* should reflect the 'context' argument"
updated_at = <Date 2022-01-06.14:44:55.790>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2022-01-06.14:44:55.790>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-06.14:44:55.790>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2022-01-06.11:36:02.498>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 46278
keywords = ['patch']
message_count = 5.0
messages = ['409829', '409837', '409843', '409846', '409852']
nosy_count = 4.0
nosy_names = ['asvetlov', 'yselivanov', 'miss-islington', 'kumaraditya']
pr_nums = ['30427', '30430', '30428', '30429', '30431', '30432']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46278'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Jan 6, 2022

    Actual implementations of asyncio event loops (both Unix and Windows) support contextvars and accept context argument in loop.call_*() methods.

    Abstract event loop definition doesn't it. It is not a bug but a signature incompatibility that can embarrass human readers and machine analyzing tools.

    @asvetlov asvetlov added topic-asyncio 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes type-bug An unexpected behavior, bug, or error labels Jan 6, 2022
    @kumaraditya303
    Copy link
    Contributor

    The PR introduced a typo in the method signature see #30427 (comment)

    @miss-islington
    Copy link
    Contributor

    New changeset b50e5e9 by Kumar Aditya in branch 'main':
    bpo-46278: fix typo introduced in #74612 (GH-30430)
    b50e5e9

    @miss-islington
    Copy link
    Contributor

    New changeset cb06831 by Miss Islington (bot) in branch '3.9':
    bpo-46278: fix typo introduced in #74612 (GH-30430)
    cb06831

    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Jan 6, 2022

    New changeset 861a9aa by Miss Islington (bot) in branch '3.10':
    bpo-46278: fix typo introduced in #74612 (GH-30430) (GH-30431)
    861a9aa

    @asvetlov asvetlov closed this as completed Jan 6, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @asvetlov @miss-islington @kumaraditya303