Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODE_OF_CONDUCT shadowing org default #90387

Closed
sobolevn opened this issue Jan 2, 2022 · 4 comments
Closed

CODE_OF_CONDUCT shadowing org default #90387

sobolevn opened this issue Jan 2, 2022 · 4 comments
Labels
3.11 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 2, 2022

BPO 46229
Nosy @brettcannon, @Mariatta, @miss-islington, @sobolevn
PRs
  • bpo-46229: remove CODE_OF_CONDUCT.md to use org default #30342
    		•
    Files
  • Снимок экрана 2022-01-02 в 23.19.15.png
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-02.23:41:14.840>
created_at = <Date 2022-01-02.20:25:16.478>
labels = ['type-bug', '3.11']
title = 'CODE_OF_CONDUCT shadowing org default'
updated_at = <Date 2022-01-02.23:41:14.839>
user = 'https://github.com/sobolevn'

    bugs.python.org fields:

    activity = <Date 2022-01-02.23:41:14.839>
actor = 'Mariatta'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-02.23:41:14.840>
closer = 'Mariatta'
components = []
creation = <Date 2022-01-02.20:25:16.478>
creator = 'sobolevn'
dependencies = []
files = ['50537']
hgrepos = []
issue_num = 46229
keywords = ['patch']
message_count = 4.0
messages = ['409519', '409530', '409542', '409545']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'Mariatta', 'miss-islington', 'sobolevn']
pr_nums = ['30342']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46229'
versions = ['Python 3.11']
    @sobolevn
    Copy link
    Member Author

    sobolevn commented Jan 2, 2022

    Problem: we have two CODE_OF_CONDUCT files.

    1. In CPython: https://github.com/python/cpython/blob/main/CODE_OF_CONDUCT.md (last updated 3 years ago)
    2. In Python org, default for all repos: https://github.com/python/.github/blob/master/CODE_OF_CONDUCT.md

    But, since CODE_OF_CONDUCT is an important document, I want to raise a discussion first. Should it be deleted from CPython repo?

    Pros: GitHub offers org-default and CODE_OF_CONDUCT will still be rendered in several places:

    It will be also easier to edit a single-source-of-truth. For example, this commit was not back-ported to CPython: python/.github@237d215

    Also, other repos like mypy / typeshed / typing use org-default CoC.

    Cons: some people might still miss that CPython has a CoC.

    This is a follow-up to: #30294

    If others agree, I can send a PR to remove CPython's local copy of CoC.

    @sobolevn sobolevn added 3.11 only security fixes type-bug An unexpected behavior, bug, or error labels Jan 2, 2022
    @Mariatta
    Copy link
    Member

    Mariatta commented Jan 2, 2022

    Sounds good to me to use the org-level CoC file and removing the local CPython copy. Having a single source of truth will be valuable and reduce our maintenance burden.

    @miss-islington
    Copy link
    Contributor

    New changeset fedefa6 by Nikita Sobolev in branch 'main':
    bpo-46229: remove CODE_OF_CONDUCT.md to use org default (GH-30342)
    fedefa6

    @Mariatta
    Copy link
    Member

    Mariatta commented Jan 2, 2022

    Thanks!

    @Mariatta Mariatta closed this as completed Jan 2, 2022
    @Mariatta Mariatta closed this as completed Jan 2, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @sobolevn @Mariatta @miss-islington