Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipaddress.ip_network TypeErrors #90299

Closed
bharel mannequin opened this issue Dec 20, 2021 · 2 comments
Closed

Fix ipaddress.ip_network TypeErrors #90299

bharel mannequin opened this issue Dec 20, 2021 · 2 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@bharel
Copy link
Mannequin

bharel mannequin commented Dec 20, 2021

BPO 46141
Nosy @taleinat, @bharel
PRs
  • bpo-46141: Fix ipaddress.ip_network TypeErrors #30087
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-12-20.22:49:03.987>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'Fix ipaddress.ip_network TypeErrors'
updated_at = <Date 2022-01-08.20:02:25.284>
user = 'https://github.com/bharel'

    bugs.python.org fields:

    activity = <Date 2022-01-08.20:02:25.284>
actor = 'taleinat'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-12-20.22:49:03.987>
creator = 'bar.harel'
dependencies = []
files = []
hgrepos = []
issue_num = 46141
keywords = []
message_count = 1.0
messages = ['408980']
nosy_count = 3.0
nosy_names = ['taleinat', 'pmoody', 'bar.harel']
pr_nums = ['30087']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46141'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @bharel
    Copy link
    Mannequin Author

    bharel mannequin commented Dec 20, 2021

    IPv4Network accepts a tuple.

    If you send a tuple to ip_network instead, it throws a TypeError while attempting to format the ValueError message.

    @bharel bharel mannequin added 3.8 only security fixes 3.10 only security fixes 3.11 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Dec 20, 2021
    @taleinat taleinat removed 3.8 only security fixes labels Jan 8, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @JelleZijlstra
    Copy link
    Member

    Fixed in #90573

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @taleinat @JelleZijlstra