Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the preferred API instead of relying on legacy for coverage #90283

Closed
jaraco opened this issue Dec 18, 2021 · 2 comments
Closed

Test the preferred API instead of relying on legacy for coverage #90283

jaraco opened this issue Dec 18, 2021 · 2 comments
Assignees
Labels
3.11 bug and security fixes stdlib Python modules in the Lib dir

Comments

@jaraco
Copy link
Member

jaraco commented Dec 18, 2021

BPO 46125
Nosy @jaraco, @FFY00
PRs
  • bpo-46125: Refactor tests to test traversable API directly. #30189
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/jaraco'
    closed_at = <Date 2022-03-20.21:11:51.292>
    created_at = <Date 2021-12-18.22:30:51.207>
    labels = ['library', '3.11']
    title = 'Test the preferred API instead of relying on legacy for coverage'
    updated_at = <Date 2022-03-20.21:11:51.292>
    user = 'https://github.com/jaraco'

    bugs.python.org fields:

    activity = <Date 2022-03-20.21:11:51.292>
    actor = 'jaraco'
    assignee = 'jaraco'
    closed = True
    closed_date = <Date 2022-03-20.21:11:51.292>
    closer = 'jaraco'
    components = ['Library (Lib)']
    creation = <Date 2021-12-18.22:30:51.207>
    creator = 'jaraco'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46125
    keywords = ['patch']
    message_count = 2.0
    messages = ['408872', '408879']
    nosy_count = 2.0
    nosy_names = ['jaraco', 'FFY00']
    pr_nums = ['30189']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue46125'
    versions = ['Python 3.11']

    @jaraco
    Copy link
    Member Author

    jaraco commented Dec 18, 2021

    importlib_resources 5.4 did some refactoring to ensure that the preferred traversable API was tested (python/importlib_resources#239). Let's incorporate those changes for importlib.resources.

    @jaraco jaraco added stdlib Python modules in the Lib dir 3.11 bug and security fixes labels Dec 18, 2021
    @jaraco jaraco self-assigned this Dec 18, 2021
    @jaraco
    Copy link
    Member Author

    jaraco commented Dec 19, 2021

    New changeset 9b52920 by Jason R. Coombs in branch 'main':
    bpo-46125: Refactor tests to test traversable API directly. Includes changes from importlib_resources 5.4.0. (GH-30189)
    9b52920

    @jaraco jaraco closed this as completed Mar 20, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant