Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules/makesetup generated rules ignore *disabled* #90181

Closed
tiran opened this issue Dec 9, 2021 · 5 comments
Closed

Modules/makesetup generated rules ignore *disabled* #90181

tiran opened this issue Dec 9, 2021 · 5 comments
Labels
3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Dec 9, 2021

BPO 46023
Nosy @tiran
PRs
  • bpo-46023: Fix makesetup handling of disabled rule (GH-30001) #30001
  • bpo-46023: Skip build if module is marked as DISABLED (GH-30100) #30100
  • bpo-46023: makesetup: skip all duplicate modules (GH-32234) #32234
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-04-01.20:04:34.867>
created_at = <Date 2021-12-09.09:23:50.892>
labels = ['type-feature', 'build', '3.11']
title = 'Modules/makesetup generated rules ignore *disabled*'
updated_at = <Date 2022-04-01.20:04:34.866>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2022-04-01.20:04:34.866>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2022-04-01.20:04:34.867>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2021-12-09.09:23:50.892>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 46023
keywords = ['patch']
message_count = 5.0
messages = ['408091', '408208', '408523', '408531', '416493']
nosy_count = 1.0
nosy_names = ['christian.heimes']
pr_nums = ['30001', '30100', '32234']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46023'
versions = ['Python 3.11']
    @tiran
    Copy link
    Member Author

    tiran commented Dec 9, 2021

    Modules/Setup can disable a module. However makesetup does not take *disabled* into account when it generated Makefile.

    Example:

    ---Modules/Setup.local

    *disabled*
    pwd
    ---

    makesetup generates a Makefile with "pwd" in MODDISABLED_NAMES and MODBUILT_NAMES. Because "pwd" is in MODBUILT_NAMES the module is built and included in python binary.

    Expected result:
    "pwd" module should not be built.

    @tiran tiran added 3.11 only security fixes build The build process and cross-build labels Dec 9, 2021
    @tiran
    Copy link
    Member Author

    tiran commented Dec 10, 2021

    New changeset 036bbb1 by Christian Heimes in branch 'main':
    bpo-46023: Fix makesetup handling of disabled rule (GH-30001)
    036bbb1

    @tiran
    Copy link
    Member Author

    tiran commented Dec 14, 2021

    #74187 may have introduced a regression. makesetup is dropping too many modules. Back to the drawing board!

    @tiran
    Copy link
    Member Author

    tiran commented Dec 14, 2021

    New changeset 74821b3 by Christian Heimes in branch 'main':
    bpo-46023: Skip build if module is marked as DISABLED (GH-30100)
    74821b3

    @tiran
    Copy link
    Member Author

    tiran commented Apr 1, 2022

    New changeset abdd69c by Christian Heimes in branch 'main':
    bpo-46023: makesetup: skip all duplicate modules (GH-32234)
    abdd69c

    @tiran tiran closed this as completed Apr 1, 2022
    @tiran tiran added the type-feature A feature request or enhancement label Apr 1, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran