Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Pipelines currently failing #90051

Closed
gvanrossum opened this issue Nov 24, 2021 · 8 comments
Closed

Azure Pipelines currently failing #90051

gvanrossum opened this issue Nov 24, 2021 · 8 comments
Assignees
@zooba
Labels
3.10 only security fixes 3.11 only security fixes build The build process and cross-build easy

Comments

@gvanrossum
Copy link
Member

BPO 45893
Nosy @gvanrossum, @vstinner, @tiran, @zooba, @miss-islington
PRs
  • bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29761
  • [3.10] bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29765
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2021-11-24.22:00:12.126>
created_at = <Date 2021-11-24.18:50:21.265>
labels = ['easy', 'build', '3.10', '3.11']
title = 'Azure Pipelines currently failing'
updated_at = <Date 2021-11-24.22:00:12.126>
user = 'https://github.com/gvanrossum'

    bugs.python.org fields:

    activity = <Date 2021-11-24.22:00:12.126>
actor = 'christian.heimes'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2021-11-24.22:00:12.126>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2021-11-24.18:50:21.265>
creator = 'gvanrossum'
dependencies = []
files = []
hgrepos = []
issue_num = 45893
keywords = ['patch', 'easy (C)']
message_count = 8.0
messages = ['406945', '406946', '406947', '406950', '406956', '406963', '406965', '406966']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'vstinner', 'christian.heimes', 'steve.dower', 'miss-islington']
pr_nums = ['29761', '29765']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue45893'
versions = ['Python 3.10', 'Python 3.11']
    @gvanrossum
    Copy link
    Member Author

    E.g. https://dev.azure.com/Python/cpython/_build/results?buildId=92084&view=results

    @gvanrossum gvanrossum added the build The build process and cross-build label Nov 24, 2021
    @gvanrossum gvanrossum added the build The build process and cross-build label Nov 24, 2021
    @zooba
    Copy link
    Member

    zooba commented Nov 24, 2021

    Seems we lost the C++ handling in Include/cpython/initconfig.h:

    #ifdef __cplusplus
extern "C" {
#endif

    <full body of file>

    #ifdef __cplusplus
}
#endif

    @zooba zooba added easy 3.11 only security fixes labels Nov 24, 2021
    @zooba
    Copy link
    Member

    zooba commented Nov 24, 2021

    Also, we should define $env:IncludeUWP="true" in the Windows PR tests. That will build extra binaries every time (that we ship in the Windows Store) and would catch this issue earlier.

    @gvanrossum
    Copy link
    Member Author

    Christian thinks that a PR by Victor broke this (GH-29488 / bpo-39026)

    @tiran tiran added 3.10 only security fixes build The build process and cross-build labels Nov 24, 2021
    @tiran
    Copy link
    Member

    tiran commented Nov 24, 2021

    New changeset f4afc53 by Christian Heimes in branch 'main':
    bpo-45893: Add missing extern C to initconfig.h (GH-29761)
    f4afc53

    @vstinner
    Copy link
    Member

    Seems we lost the C++ handling in Include/cpython/initconfig.h

    I was never in initconfig.h since the PEP-587 (PyConfig C API) was implemented. I'm not sure why the build *started* to fail on Windows.

    Thanks for fixing the issue ;-)

    @miss-islington
    Copy link
    Contributor

    New changeset cd85d91 by Miss Islington (bot) in branch '3.10':
    bpo-45893: Add missing extern C to initconfig.h (GH-29761)
    cd85d91

    @tiran
    Copy link
    Member

    tiran commented Nov 24, 2021

    You are welcome!

    @tiran tiran closed this as completed Nov 24, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.10 only security fixes 3.11 only security fixes build The build process and cross-build easy
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @vstinner @tiran @zooba @gvanrossum @miss-islington