Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PyImport_ImportModuleNoBlock with PyImport_ImportModule in std modules #90013

Closed
birkenfeld opened this issue Nov 20, 2021 · 5 comments
Closed
Labels
3.11 bug and security fixes topic-C-API type-feature A feature request or enhancement

Comments

@birkenfeld
Copy link
Member

BPO 45855
Nosy @birkenfeld, @asvetlov, @kumaraditya303
PRs
  • bpo-45855: document that no_block has no use anymore in PyCapsule_Import #29665
  • bpo-45855: Replaced deprecated PyImport_ImportModuleNoBlock with PyIm… #30046
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-12-12.09:50:44.284>
    created_at = <Date 2021-11-20.16:27:18.444>
    labels = ['expert-C-API', 'type-feature', '3.11']
    title = 'Replace PyImport_ImportModuleNoBlock with PyImport_ImportModule in std modules'
    updated_at = <Date 2021-12-12.09:50:44.284>
    user = 'https://github.com/birkenfeld'

    bugs.python.org fields:

    activity = <Date 2021-12-12.09:50:44.284>
    actor = 'georg.brandl'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-12-12.09:50:44.284>
    closer = 'georg.brandl'
    components = ['C API']
    creation = <Date 2021-11-20.16:27:18.444>
    creator = 'georg.brandl'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45855
    keywords = ['patch']
    message_count = 5.0
    messages = ['406671', '406672', '408010', '408369', '408371']
    nosy_count = 3.0
    nosy_names = ['georg.brandl', 'asvetlov', 'kumaraditya']
    pr_nums = ['29665', '30046']
    priority = 'low'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue45855'
    versions = ['Python 3.11']

    @birkenfeld
    Copy link
    Member Author

    PyImport_ImportModuleNoBlock is the same as PyImport_ImportModule since 3.3, according to the docs.

    PyCapsule_Import has a no_block parameter to choose, is still documented as if it is relevant, and the implementation also still uses it.

    @birkenfeld birkenfeld added 3.10 only security fixes topic-C-API type-feature A feature request or enhancement labels Nov 20, 2021
    @birkenfeld
    Copy link
    Member Author

    PR is underway.

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Dec 8, 2021

    The main branch has a dozen PyImport_ImportModuleNoBlock() usages.

    Would you replace them also?

    @asvetlov asvetlov added 3.11 bug and security fixes and removed 3.10 only security fixes labels Dec 8, 2021
    @asvetlov
    Copy link
    Contributor

    New changeset 41026c3 by Kumar Aditya in branch 'main':
    bpo-45855: Replaced deprecated PyImport_ImportModuleNoBlock with PyImport_ImportModule (GH-30046)
    41026c3

    @asvetlov asvetlov changed the title PyCapsule_Import still using PyImport_ImportModuleNoBlock Replace PyImport_ImportModuleNoBlock with PyImport_ImportModule in std modules Dec 12, 2021
    @birkenfeld birkenfeld reopened this Dec 12, 2021
    @birkenfeld
    Copy link
    Member Author

    New changeset f4095e5 by Georg Brandl in branch 'main':
    bpo-45855: document that no_block has no use anymore in PyCapsule_Import (bpo-29665)
    f4095e5

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes topic-C-API type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants