Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expat handling into configure and Makefile #89958

Closed
tiran opened this issue Nov 13, 2021 · 3 comments
Closed

Move expat handling into configure and Makefile #89958

tiran opened this issue Nov 13, 2021 · 3 comments
Assignees
Labels
3.11 bug and security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Nov 13, 2021

BPO 45800
Nosy @tiran
PRs
  • bpo-45800: Move pyexpat build setup into configure (GH-29547) #29547
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
    closed_at = <Date 2021-11-14.09:02:39.871>
    created_at = <Date 2021-11-13.15:37:55.365>
    labels = ['type-feature', 'build', '3.11']
    title = 'Move expat handling into configure and Makefile'
    updated_at = <Date 2021-11-14.09:02:40.315>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-11-14.09:02:40.315>
    actor = 'christian.heimes'
    assignee = 'christian.heimes'
    closed = True
    closed_date = <Date 2021-11-14.09:02:39.871>
    closer = 'christian.heimes'
    components = ['Build']
    creation = <Date 2021-11-13.15:37:55.365>
    creator = 'christian.heimes'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45800
    keywords = ['patch']
    message_count = 3.0
    messages = ['406281', '406282', '406312']
    nosy_count = 1.0
    nosy_names = ['christian.heimes']
    pr_nums = ['29547']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue45800'
    versions = ['Python 3.11']

    @tiran
    Copy link
    Member Author

    tiran commented Nov 13, 2021

    Move logic for --with-system-expat out of setup.py into configure and Makefile. This will enable --with-system-expat in Modules/Setup without manual patching.

    • Set CFLAGS and LDFLAGS for pyexpat and libexpat in configure.
    • Build a static libexpat.a from our copy of expat when --with-system-expat is not given
    • Either link pyexpat with libexpat.a or system libexpat.

    Basically use the same approach as decimal changeset bpo-45798.

    @tiran tiran added the 3.11 bug and security fixes label Nov 13, 2021
    @tiran tiran self-assigned this Nov 13, 2021
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement 3.11 bug and security fixes labels Nov 13, 2021
    @tiran tiran self-assigned this Nov 13, 2021
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement labels Nov 13, 2021
    @tiran
    Copy link
    Member Author

    tiran commented Nov 13, 2021

    An intermediate libexpat.a simplifies Modules/Setup.

    The explicit rules are required to support BSD make. bmake does neither have "%.o: %.c" nor target variable overrides like GNU make.

    @tiran
    Copy link
    Member Author

    tiran commented Nov 14, 2021

    New changeset 464e661 by Christian Heimes in branch 'main':
    bpo-45800: Move pyexpat build setup into configure (GH-29547)
    464e661

    @tiran tiran closed this as completed Nov 14, 2021
    @tiran tiran closed this as completed Nov 14, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant