Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid allocating when exiting frame; it may be unsafe. #89944

Closed
markshannon opened this issue Nov 11, 2021 · 6 comments
Closed

Avoid allocating when exiting frame; it may be unsafe. #89944

markshannon opened this issue Nov 11, 2021 · 6 comments
Assignees
@markshannon
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@markshannon
Copy link
Member

BPO 45786
Nosy @vstinner, @markshannon, @pablogsal
PRs
  • bpo-45786: Allocate space for frame in frame object. #29729
  • bpo-45786: Remove _PyFrame_Fini() and _PyFrame_DebugMallocStats() #31874
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/markshannon'
closed_at = <Date 2022-01-13.18:35:35.826>
created_at = <Date 2021-11-11.15:04:09.759>
labels = ['interpreter-core', 'type-crash', '3.11']
title = 'Avoid allocating when exiting frame; it may be unsafe.'
updated_at = <Date 2022-03-18.10:17:20.770>
user = 'https://github.com/markshannon'

    bugs.python.org fields:

    activity = <Date 2022-03-18.10:17:20.770>
actor = 'vstinner'
assignee = 'Mark.Shannon'
closed = True
closed_date = <Date 2022-01-13.18:35:35.826>
closer = 'Mark.Shannon'
components = ['Interpreter Core']
creation = <Date 2021-11-11.15:04:09.759>
creator = 'Mark.Shannon'
dependencies = []
files = []
hgrepos = []
issue_num = 45786
keywords = ['patch', '3.11regression']
message_count = 6.0
messages = ['406163', '406165', '406166', '407271', '410506', '415480']
nosy_count = 3.0
nosy_names = ['vstinner', 'Mark.Shannon', 'pablogsal']
pr_nums = ['29729', '31874']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue45786'
versions = ['Python 3.11']
    @markshannon
    Copy link
    Member Author

    We exiting a frame (returning from a Python function) we have to release the stack allocated frame. If a heap-allocated frame object exists, we need to copy the contents of the (stack) frame into the frame object.
    However, this involves allocating memory for the copy. Allocating memory can invoke GC, causing arbitrary code to be run, or the allocation can fail. Either leaves us in a precarious state, which may be unsafe.

    I haven't been able to produce a crash, but I'm not sure that there isn't a potential crash lurking there either.

    The fix is fairly simple. Allocate space for the copy of the frame at the end of the frame object. Then we need to copy the data, space will have already been allocated, and nothing can fail.

    Since, in theory, heap-allocated frames are relatively rare, the extra memory used won't be an issue.

    @markshannon markshannon added the 3.11 only security fixes label Nov 11, 2021
    @markshannon markshannon self-assigned this Nov 11, 2021
    @markshannon markshannon added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump labels Nov 11, 2021
    @pablogsal
    Copy link
    Member

    Allocating memory can invoke GC

    Technically, only allocating objects can trigger GC (specifically initializing them). All the malloc APIs don't currently call the GC by themselves.

    @markshannon
    Copy link
    Member Author

    Ok, so it is not as bad as I thought.

    A failed allocation might leave us with an invalid frameobject, though. So it is still worth fixing.

    @markshannon
    Copy link
    Member Author

    New changeset 6092957 by Mark Shannon in branch 'main':
    bpo-45786: Allocate space for frame in frame object. (GH-29729)
    6092957

    @markshannon
    Copy link
    Member Author

    With https://bugs.python.org/issue45963 both frame objects and generators contain space for the frame, so no allocation occurs on exit.

    @vstinner
    Copy link
    Member

    New changeset 2217462 by Victor Stinner in branch 'main':
    bpo-45786: Remove _PyFrame_Fini() and _PyFrame_DebugMallocStats() (GH-31874)
    2217462

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @markshannon markshannon

    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @markshannon @pablogsal