Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python.org Windows and macOS installers use Tk 8.6.12 #89895

Closed
ned-deily opened this issue Nov 5, 2021 · 11 comments
Closed

Make python.org Windows and macOS installers use Tk 8.6.12 #89895

ned-deily opened this issue Nov 5, 2021 · 11 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build OS-mac OS-windows

Comments

@ned-deily
Copy link
Member

BPO 45732
Nosy @terryjreedy, @pfmoore, @ronaldoussoren, @tjguk, @ned-deily, @zware, @zooba, @aivarannamaa
PRs
  • bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 #29477
  • [3.10] bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477) #29493
  • [3.9] bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477) #29496
  • bpo-45732: Update python.org macOS installer to use Tcl/Tk 8.6.12. #29931
  • [3.10] bpo-45732: Update python.org macOS installer to use Tcl/Tk 8.6.12. #29932
  • [3.9] bpo-45732: Update python.org macOS installer to use Tcl/Tk 8.6.12. #29933
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-12-06.07:48:20.086>
    created_at = <Date 2021-11-05.23:15:21.021>
    labels = ['OS-mac', '3.9', '3.10', '3.11', 'build', 'OS-windows']
    title = 'Make python.org Windows and macOS installers use Tk 8.6.12'
    updated_at = <Date 2021-12-06.07:48:20.085>
    user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2021-12-06.07:48:20.085>
    actor = 'ned.deily'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-12-06.07:48:20.086>
    closer = 'ned.deily'
    components = ['Build', 'macOS', 'Windows']
    creation = <Date 2021-11-05.23:15:21.021>
    creator = 'ned.deily'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45732
    keywords = ['patch']
    message_count = 11.0
    messages = ['405834', '405974', '406029', '406035', '406040', '406414', '407360', '407378', '407770', '407771', '407772']
    nosy_count = 8.0
    nosy_names = ['terry.reedy', 'paul.moore', 'ronaldoussoren', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'aivarannamaa']
    pr_nums = ['29477', '29493', '29496', '29931', '29932', '29933']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue45732'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @ned-deily
    Copy link
    Member Author

    @ned-deily ned-deily added 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build OS-mac OS-windows labels Nov 5, 2021
    @zooba
    Copy link
    Member

    zooba commented Nov 8, 2021

    I guess I've actually got to fix my build process now :)

    @zooba
    Copy link
    Member

    zooba commented Nov 9, 2021

    New changeset bcc4e46 by Steve Dower in branch 'main':
    bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
    bcc4e46

    @zooba
    Copy link
    Member

    zooba commented Nov 9, 2021

    New changeset 340ecaf by Steve Dower in branch '3.10':
    bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
    340ecaf

    @zooba
    Copy link
    Member

    zooba commented Nov 9, 2021

    New changeset 4d1cdd7 by Steve Dower in branch '3.9':
    bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
    4d1cdd7

    @terryjreedy terryjreedy changed the title Update python.org Windows and macOS installers to use Tk 8.6.12 Make python.org Windows and macOS installers use Tk 8.6.12 Nov 12, 2021
    @terryjreedy terryjreedy changed the title Update python.org Windows and macOS installers to use Tk 8.6.12 Make python.org Windows and macOS installers use Tk 8.6.12 Nov 12, 2021
    @terryjreedy
    Copy link
    Member

    Steve, thank you for patching all current versions. Previous policy has been to freeze tcl/tk x.y.z in python x.y because tk x.y.z may include a few enhancements among the bug fixes and hence indirectly add new features to tkinter in python x.y.z. However ...

    E.Paine's report for this bugfix
    "2021-09-21 (bug)[033886] Win: hang in font loading (e-paine,vogel)"
    was the result of bpo-45103, based on an IDLE user's SO question about IDLE's config dialog hanging. It turned out that adding a particular font (Phaistos) to Windows was the cause, and the fix was to remove it. Ned's link specifically says they fixed " - Windows loading of the Phaistos font.", so I can now close our bpo-45103.

    Fine with me if we continue to update tcl/tk 8.6.z as possible on Windows as well as Mac. Switching to 8.7, when released, would likely have to wait for discussion and a new Python version, which now is never too far away.

    @aivarannamaa
    Copy link
    Mannequin

    aivarannamaa mannequin commented Nov 30, 2021

    Do I understand properly, that the macOS build hasn't been updated yet?

    It would be really great if Python 3.10.1 for macOS would come with Tcl/Tk 8.6.12, as it is supposed to fix a nasty crash with Spanish keyboard.

    @ned-deily
    Copy link
    Member Author

    It would be really great if Python 3.10.1 for macOS would come with Tcl/Tk 8.6.12, as it is supposed to fix a nasty crash with Spanish keyboard.

    Not to worry, the Tk for the macOS 3.10.1 will be updated. I need to do some more testing first. (BTW, I assume you are referring to this Tk issue: https://core.tcl-lang.org/tk/tktview/1626ed65b879bd76db99. The most recent 3.11.0 alpha preview has a pre-release of 8.6.12 and I can confirm that the Cmd-` with the Spanish keyboard no longer crashes with it.)

    @ned-deily
    Copy link
    Member Author

    New changeset 2080198 by Ned Deily in branch '3.10':
    bpo-45732: Update python.org macOS installer to use Tcl/Tk 8.6.12. (GH-29932)
    2080198

    @ned-deily
    Copy link
    Member Author

    New changeset 7accb4f by Ned Deily in branch '3.9':
    bpo-45732: Update python.org macOS installer to use Tcl/Tk 8.6.12. (GH-29933)
    7accb4f

    @ned-deily
    Copy link
    Member Author

    New changeset f34d181 by Ned Deily in branch 'main':
    bpo-45732: Update python.org macOS installer to use Tcl/Tk 8.6.12. (GH-29931)
    f34d181

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build OS-mac OS-windows
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants