Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle --enable-loadable-sqlite-extensions in configure #89894

Closed
tiran opened this issue Nov 5, 2021 · 2 comments
Closed

Handle --enable-loadable-sqlite-extensions in configure #89894

tiran opened this issue Nov 5, 2021 · 2 comments
Assignees
@tiran
Labels
3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Nov 5, 2021

BPO 45731
Nosy @tiran, @erlend-aasland
PRs
  • bpo-45731: Handle --enable-loadable-sqlite-extensions in configure (GH-29434) #29434
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2021-11-06.09:30:54.006>
created_at = <Date 2021-11-05.19:55:46.451>
labels = ['type-feature', 'build', '3.11']
title = 'Handle --enable-loadable-sqlite-extensions in configure'
updated_at = <Date 2021-11-06.09:30:54.006>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-11-06.09:30:54.006>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2021-11-06.09:30:54.006>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2021-11-05.19:55:46.451>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 45731
keywords = ['patch']
message_count = 2.0
messages = ['405826', '405852']
nosy_count = 2.0
nosy_names = ['christian.heimes', 'erlendaasland']
pr_nums = ['29434']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45731'
versions = ['Python 3.11']
    @tiran
    Copy link
    Member Author

    tiran commented Nov 5, 2021

    The --enable-loadable-sqlite-extensions configure option is currently handled by a check in setup.py. The approach is incompatible with Modules/Setup and yields incorrect results for --enable-loadable-sqlite-extensions=no. Instead of reading the value from CONFIG_ARGS, configure should add an AC_DEFINE to pyconfig.h

    @tiran tiran added the 3.11 only security fixes label Nov 5, 2021
    @tiran tiran self-assigned this Nov 5, 2021
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement 3.11 only security fixes labels Nov 5, 2021
    @tiran tiran self-assigned this Nov 5, 2021
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement labels Nov 5, 2021
    @tiran
    Copy link
    Member Author

    tiran commented Nov 6, 2021

    New changeset e9594f6 by Christian Heimes in branch 'main':
    bpo-45731: Handle --enable-loadable-sqlite-extensions in configure (GH-29434)
    e9594f6

    @tiran tiran closed this as completed Nov 6, 2021
    @tiran tiran closed this as completed Nov 6, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran