Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some PGO tests are failing when building with --enable-optimizations --disable-test-modules #89831

Closed
tiran opened this issue Oct 29, 2021 · 4 comments
Closed

Some PGO tests are failing when building with --enable-optimizations --disable-test-modules #89831

tiran opened this issue Oct 29, 2021 · 4 comments
Labels
3.11 only security fixes build The build process and cross-build tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Oct 29, 2021

BPO 45668
Nosy @tiran, @thesamesam
PRs
  • bpo-45668: Fix PGO tests without test extensions (GH-29315) #29315
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-11-01.11:18:19.551>
created_at = <Date 2021-10-29.14:37:29.097>
labels = ['type-bug', 'tests', 'build', '3.11']
title = 'Some PGO tests are failing when building with --enable-optimizations --disable-test-modules'
updated_at = <Date 2021-11-01.11:18:19.551>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-11-01.11:18:19.551>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2021-11-01.11:18:19.551>
closer = 'christian.heimes'
components = ['Build', 'Tests']
creation = <Date 2021-10-29.14:37:29.097>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 45668
keywords = ['patch']
message_count = 2.0
messages = ['405308', '405425']
nosy_count = 2.0
nosy_names = ['christian.heimes', 'thesamesam']
pr_nums = ['29315']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45668'
versions = ['Python 3.11']
    @tiran
    Copy link
    Member Author

    tiran commented Oct 29, 2021

    Some PGO tests are failing when Python is build with options ./configure --disable-test-modules --enable-optimizations . Test failures are caused by missing _testcapi module.

    ./python -m test --pgo --timeout=1200 || true
    test test_array failed
    test test_bytes failed
    test test_cmath failed
    test test_codecs failed
    0:00:23 load avg: 1.98 [13/44] test_datetime
    Failed to call load_tests:
    ...
    ModuleNotFoundError: No module named '_testcapi'
    test test_embed failed
    test test_float failed
    test test_itertools failed
    test test_ordered_dict failed
    test test_pickle failed
    test test_struct failed
    test test_unicode failed
    test test_xml_etree_c failed
    test_xml_etree_c failed (3 errors)

    @tiran tiran added 3.11 only security fixes build The build process and cross-build tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Oct 29, 2021
    @tiran
    Copy link
    Member Author

    tiran commented Nov 1, 2021

    New changeset e73283a by Christian Heimes in branch 'main':
    bpo-45668: Fix PGO tests without test extensions (GH-29315)
    e73283a

    @tiran tiran closed this as completed Nov 1, 2021
    @tiran tiran closed this as completed Nov 1, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    htmltiger referenced this issue Mar 24, 2023
    @vstinner
    bpo-46906: Add PyFloat_Pack8() to the C API (GH-31657)
    882d809 
    Add new functions to pack and unpack C double (serialize and
deserialize):

* PyFloat_Pack2(), PyFloat_Pack4(), PyFloat_Pack8()
* PyFloat_Unpack2(), PyFloat_Unpack4(), PyFloat_Unpack8()

Document these functions and add unit tests.

Rename private functions and move them from the internal C API
to the public C API:

* _PyFloat_Pack2() => PyFloat_Pack2()
* _PyFloat_Pack4() => PyFloat_Pack4()
* _PyFloat_Pack8() => PyFloat_Pack8()
* _PyFloat_Unpack2() => PyFloat_Unpack2()
* _PyFloat_Unpack4() => PyFloat_Unpack4()
* _PyFloat_Unpack8() => PyFloat_Unpack8()

Replace the "unsigned char*" type with "char*" which is more common
and easy to use.
    @htmltiger
    Copy link

    @tiran this is failing again in 3.11.2 as the changes are now no longer in the file
    882d809#r105830468

    @vstinner
    Copy link
    Member

    vstinner commented Apr 5, 2023

    @tiran this is failing again in 3.11.2 as the changes are now no longer in the file

    Hi. This issue is closed. Please open a new issue. It's even better if you propose a PR to fix the issue :-)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes build The build process and cross-build tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @tiran @htmltiger