Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect repr of InitVar of a type alias #89825

Closed
Tracked by #89828
serhiy-storchaka opened this issue Oct 28, 2021 · 4 comments
Closed
Tracked by #89828

Incorrect repr of InitVar of a type alias #89825

serhiy-storchaka opened this issue Oct 28, 2021 · 4 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 45662
Nosy @gvanrossum, @ericvsmith, @serhiy-storchaka, @miss-islington
PRs
  • bpo-45662: Fix the repr of InitVar with a type alias to the built-in class #29291
  • [3.10] bpo-45662: Fix the repr of InitVar with a type alias to the built-in class (GH-29291) #29923
  • [3.9] bpo-45662: Fix the repr of InitVar with a type alias to the built-in class (GH-29291) #29924
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-12-10.09:47:23.655>
    created_at = <Date 2021-10-28.19:46:03.203>
    labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
    title = 'Incorrect repr of InitVar of a type alias'
    updated_at = <Date 2021-12-10.09:47:23.654>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2021-12-10.09:47:23.654>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-12-10.09:47:23.655>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2021-10-28.19:46:03.203>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45662
    keywords = ['patch']
    message_count = 4.0
    messages = ['405241', '407738', '407742', '408184']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'eric.smith', 'serhiy.storchaka', 'miss-islington']
    pr_nums = ['29291', '29923', '29924']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45662'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @serhiy-storchaka
    Copy link
    Member Author

    The repr of InitVar preserves type aliases from the typing module, but not builtin.

    >>> import typing, dataclasses
    >>> dataclasses.InitVar[typing.List[int]]
    dataclasses.InitVar[typing.List[int]]
    >>> dataclasses.InitVar[list[int]]
    dataclasses.InitVar[list]

    @serhiy-storchaka serhiy-storchaka added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Oct 28, 2021
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 1fd4de5 by Serhiy Storchaka in branch 'main':
    bpo-45662: Fix the repr of InitVar with a type alias to the built-in class (GH-29291)
    1fd4de5

    @miss-islington
    Copy link
    Contributor

    New changeset f1dd5ed by Miss Islington (bot) in branch '3.10':
    bpo-45662: Fix the repr of InitVar with a type alias to the built-in class (GH-29291)
    f1dd5ed

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset fb8aad1 by Miss Islington (bot) in branch '3.9':
    [3.9] bpo-45662: Fix the repr of InitVar with a type alias to the built-in class (GH-29291) (GH-29924)
    fb8aad1

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants