Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production tokens are not clickable #89803

Closed
Arthur-Milchior mannequin opened this issue Oct 28, 2021 · 4 comments
Closed

Production tokens are not clickable #89803

Arthur-Milchior mannequin opened this issue Oct 28, 2021 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir

Comments

@Arthur-Milchior
Copy link
Mannequin

Arthur-Milchior mannequin commented Oct 28, 2021

BPO 45640
Nosy @ambv, @miss-islington, @Arthur-Milchior
PRs
  • bpo-45640: Tokens are now clickable #29260
  • [3.10] bpo-45640: [docs] Tokens are now clickable (GH-29260) #29621
  • [3.9] bpo-45640: [docs] Tokens are now clickable (GH-29260) #29623
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-11-18.18:37:58.083>
created_at = <Date 2021-10-28.03:04:26.553>
labels = ['3.8', '3.9', '3.10', '3.11', '3.7', 'docs']
title = 'Production tokens are not clickable'
updated_at = <Date 2021-11-18.18:37:58.082>
user = 'https://github.com/Arthur-Milchior'

    bugs.python.org fields:

    activity = <Date 2021-11-18.18:37:58.082>
actor = 'lukasz.langa'
assignee = 'docs@python'
closed = True
closed_date = <Date 2021-11-18.18:37:58.083>
closer = 'lukasz.langa'
components = ['Documentation']
creation = <Date 2021-10-28.03:04:26.553>
creator = 'Arthur-Milchior'
dependencies = []
files = []
hgrepos = []
issue_num = 45640
keywords = ['patch']
message_count = 4.0
messages = ['405147', '406546', '406554', '406559']
nosy_count = 4.0
nosy_names = ['docs@python', 'lukasz.langa', 'miss-islington', 'Arthur-Milchior']
pr_nums = ['29260', '29621', '29623']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45640'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']
    @Arthur-Milchior
    Copy link
    Mannequin Author

    Arthur-Milchior mannequin commented Oct 28, 2021

    In the current documentation, production tokens are not clickable. For example in https://docs.python.org/3/reference/expressions.html#yield-expressions , you highlight `yield_from` as a token but do not link to it.
    I suppose that the goal, when using :token:`yeld_from`, was to ensure that the token links to its definition. However, Sphinx require to use :token:`~python-grammar:yeld_from` for the link to appear.

    I suggest adding ~python-grammar after each token:.

    @Arthur-Milchior Arthur-Milchior mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Oct 28, 2021
    @Arthur-Milchior Arthur-Milchior mannequin added docs Documentation in the Doc dir 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Oct 28, 2021
    @Arthur-Milchior Arthur-Milchior mannequin added the docs Documentation in the Doc dir label Oct 28, 2021
    @ambv
    Copy link
    Contributor

    ambv commented Nov 18, 2021

    New changeset 3295910 by Arthur Milchior in branch 'main':
    bpo-45640: [docs] Tokens are now clickable (GH-29260)
    3295910

    @ambv
    Copy link
    Contributor

    ambv commented Nov 18, 2021

    New changeset 252d83c by Miss Islington (bot) in branch '3.10':
    bpo-45640: [docs] Tokens are now clickable (GH-29260) (GH-29621)
    252d83c

    @ambv
    Copy link
    Contributor

    ambv commented Nov 18, 2021

    We won't be backporting this to 3.9 due to make suspicious being faulty on this version. More details on #73809.

    So this is fixed on 3.10 and 3.11. Thanks, Arthur! ✨ 🍰 ✨

    @ambv ambv closed this as completed Nov 18, 2021
    @ambv ambv closed this as completed Nov 18, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @ambv